New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nadrop #1810

Merged
merged 3 commits into from Dec 4, 2018

Conversation

Projects
None yet
3 participants
@yaeldekel
Member

yaeldekel commented Dec 3, 2018

Fixes #1809 .

@yaeldekel yaeldekel requested review from Ivanidzo4ka and sfilipi Dec 3, 2018

@@ -204,7 +204,7 @@ protected override Delegate MakeGetter(IRow input, int iinfo, Func<int, bool> ac
private ValueGetter<VBuffer<TDst>> MakeVecGetter<TDst>(IRow input, int iinfo)
{
var srcGetter = input.GetGetter<VBuffer<TDst>>(iinfo);
var srcGetter = input.GetGetter<VBuffer<TDst>>(_srcCols[iinfo]);

This comment has been minimized.

@sfilipi

sfilipi Dec 4, 2018

Member

(_srcCols[iinfo]); [](start = 62, length = 18)

might be worth we check the other transforms for this bug... #WontFix

@sfilipi

sfilipi approved these changes Dec 4, 2018

:shipit:

@yaeldekel yaeldekel merged commit 8a9b016 into dotnet:master Dec 4, 2018

2 checks passed

MachineLearning-CI #20181203.12 succeeded
Details
license/cla All CLA requirements met.
Details

@yaeldekel yaeldekel deleted the yaeldekel:nadrop branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment