-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Added RffBenchmark #1855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Added RffBenchmark #1855
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using BenchmarkDotNet.Attributes; | ||
| using Microsoft.ML.Runtime.Data; | ||
| using Microsoft.ML.Runtime.RunTests; | ||
| using Microsoft.ML.Transforms.Conversions; | ||
| using System.IO; | ||
|
|
||
| namespace Microsoft.ML.Benchmarks | ||
| { | ||
| public class RffTransformTrain | ||
| { | ||
| private string _dataPath_Digits; | ||
|
|
||
| [GlobalSetup] | ||
| public void SetupTrainingSpeedTests() | ||
| { | ||
| _dataPath_Digits = Path.GetFullPath(TestDatasets.Digits.trainFilename); | ||
|
|
||
| if (!File.Exists(_dataPath_Digits)) | ||
| throw new FileNotFoundException(string.Format(Errors.DatasetNotFound, _dataPath_Digits)); | ||
| } | ||
|
|
||
| [Benchmark] | ||
| public void CV_Multiclass_Digits_RffTransform_OVAAveragedPerceptron() | ||
| { | ||
| var mlContext = new MLContext(); | ||
| var reader = mlContext.Data.CreateTextReader(new TextLoader.Arguments | ||
| { | ||
| Column = new[] | ||
| { | ||
| new TextLoader.Column("Label", DataKind.R4, 64), | ||
| new TextLoader.Column("Features", DataKind.R4, new [] { new TextLoader.Range() { Min = 0, Max = 63 }}) | ||
| }, | ||
| HasHeader = false, | ||
| Separator = "," | ||
| }); | ||
|
|
||
| var data = reader.Read(_dataPath_Digits); | ||
|
|
||
| var pipeline = mlContext.Transforms.Projection.CreateRandomFourierFeatures("Features", "FeaturesRFF") | ||
| .AppendCacheCheckpoint(mlContext) | ||
| .Append(mlContext.Transforms.Concatenate("Features", "FeaturesRFF")) | ||
| .Append(new ValueToKeyMappingEstimator(mlContext, "Label")) | ||
| .Append(mlContext.MulticlassClassification.Trainers.OneVersusAll(mlContext.BinaryClassification.Trainers.AveragedPerceptron(numIterations: 10))); | ||
|
|
||
| var cvResults = mlContext.MulticlassClassification.CrossValidate(data, pipeline, numFolds: 5); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try to play with swapping lines 45 and 46? I believe this may be how our auto-caching used to work.
Also, this might expose the need to specify 'prefetchColumns' to avoid overly lazy caching. See the Cache method in DataOperations.cs line 35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this but still getting the same result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how can we use this in this benchmark ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zruty0: Do we have documentation on how/where/when to do caching?