Skip to content

Remove "Runtime" from all namespace reference and move public facing classes used in Samples into Microsoft.ML namespace. #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Remove "Runtime" from all namespace reference and move public facing classes used in Samples into Microsoft.ML namespace. #1937

wants to merge 7 commits into from

Conversation

@codemzs
Copy link
Member

@codemzs codemzs commented Dec 20, 2018

fixes #1697

@codemzs
Remove Runtime from all namespaces.
83ea473
@codemzs
fix test.
f83f440
@codemzs
Merge branch 'master' of https://github.com/dotnet/machinelearning in…
5ae27c5 
…to runtimens

# Conflicts:
#	docs/samples/Microsoft.ML.Samples/Static/LightGBMBinaryClassification.cs
#	docs/samples/Microsoft.ML.Samples/Static/LightGBMRegression.cs
#	src/Microsoft.ML.Data/Prediction/PredictionFunction.cs
#	src/Microsoft.ML.HalLearners.StaticPipe/VectorWhiteningStaticExtensions.cs
#	src/Microsoft.ML.LightGBM.StaticPipe/LightGbmStaticExtensions.cs
#	src/Microsoft.ML.StandardLearners/Standard/ModelStatistics.cs
#	src/Microsoft.ML.StaticPipe/LdaStaticExtensions.cs
#	src/Microsoft.ML.StaticPipe/NormalizerStaticExtensions.cs
#	src/Microsoft.ML.StaticPipe/SdcaStaticExtensions.cs
#	src/Microsoft.ML.StaticPipe/TermStaticExtensions.cs
#	src/Microsoft.ML.StaticPipe/TermStaticExtensions.tt
#	src/Microsoft.ML.StaticPipe/TransformsStatic.cs
#	src/Microsoft.ML.TensorFlow/TensorFlowModelInfo.cs
#	test/Microsoft.ML.OnnxTransformTest/DnnImageFeaturizerTest.cs
#	test/Microsoft.ML.OnnxTransformTest/OnnxTransformTests.cs
#	test/Microsoft.ML.StaticPipelineTesting/StaticPipeTests.cs
#	test/Microsoft.ML.StaticPipelineTesting/Training.cs
#	test/Microsoft.ML.Tests/TensorFlowEstimatorTests.cs
#	test/Microsoft.ML.Tests/TrainerEstimators/TreeEstimators.cs
#	test/Microsoft.ML.Tests/Transformers/TextFeaturizerTests.cs
@codemzs
merge errors.
cecb895
@codemzs
Move public facing components to Microsoft.ML namespace and related s…
2b23a3f 
…tuff.
@codemzs
Merge branch 'master' of https://github.com/dotnet/machinelearning in…
9a30dfb 
…to runtimens

# Conflicts:
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance.cs
#	src/Microsoft.ML.EntryPoints/CrossValidationBinaryMacro.cs
#	src/Microsoft.ML.EntryPoints/ImportTextData.cs
#	src/Microsoft.ML.EntryPoints/JsonUtils/JsonManifestUtils.cs
#	src/Microsoft.ML.EntryPoints/MacroUtils.cs
#	src/Microsoft.ML.EntryPoints/ModelOperations.cs
#	src/Microsoft.ML.EntryPoints/OneVersusAllMacro.cs
#	src/Microsoft.ML.EntryPoints/TrainTestBinaryMacro.cs
#	src/Microsoft.ML.EntryPoints/TrainTestMacro.cs
#	src/Microsoft.ML.Legacy/CSharpApi.cs
#	src/Microsoft.ML.Legacy/Models/CrossValidator.cs
#	src/Microsoft.ML.Legacy/Models/TrainTestEvaluator.cs
#	src/Microsoft.ML.Transforms/PermutationFeatureImportanceExtensions.cs
#	test/BaselineOutput/Common/EntryPoints/core_ep-list.tsv
#	test/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
@codemzs
merge error fixes.
c8ee273
@codemzs codemzs requested review from artidoro and sfilipi December 20, 2018 03:22
@TomFinley
Copy link
Contributor

TomFinley commented Dec 20, 2018

Hi @codemzs thanks for looking at this.

One thing you'll note is that you've changed 917 files. This means that both codeflow and the git web review are overwhelmed, since codeflow can only display so many files at a time. The git web tool is an inadequate tool at the best of times.

So basically, I'm unsure how to review this. This PR seems way, way too large. What would you recommend?

@TomFinley
Copy link
Contributor

TomFinley commented Dec 20, 2018

I might recommend that the original plan, which I thought involved a more gradual approach, easier to review and more incremental, would be appropriate. In particular lots of things seem to have been moved to namespaces where they clearly don't belong (e.g., BinaryLoader has been moved to Microsoft.ML), which makes me nervous. That's just one of the things I can see in the few files that are showing up (since, of course it can't show me all of them), which makes me nervous.

@Ivanidzo4ka
Copy link
Contributor

Ivanidzo4ka commented Dec 20, 2018

I've see some changes like:
Microsoft.ML.Runtime.Internal.Utilities -> Microsoft.ML.Internal.Utilities.
In Issue you referencing, I don't see any mentions about removing Runtime from namespace names.
Is it described in another issue? Can you link it?

@TomFinley
Copy link
Contributor

TomFinley commented Dec 25, 2018

Hi @codemzs , given #1956 is in, this seems to be obsolete. Want to close?

@codemzs
Copy link
Member Author

codemzs commented Dec 25, 2018

@TomFinley Yes, I have closed it.

@codemzs codemzs closed this Dec 25, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@artidoro artidoro Awaiting requested review from artidoro

@sfilipi sfilipi Awaiting requested review from sfilipi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove "Runtime" from all namespace reference, sort namespaces as per .net convention and enforce the same.

3 participants

@codemzs @TomFinley @Ivanidzo4ka