Use channel info in SymSGD #1989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomFinley
reviewed
Dec 31, 2018
|
|
||
| // Local weightScaling for L2 regularization | ||
| float _weightScaling, _startWeightScaling; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
TomFinley
reviewed
Dec 31, 2018
| }; | ||
| }; | ||
|
|
||
| // Loggin call back signature for ML.NET |
Contributor
There was a problem hiding this comment.
Loggin [](start = 3, length = 6)
Typo. Though, "Loggin' call" sounds like it could be the title to a catchy 19th century folk song.
TomFinley
approved these changes
Dec 31, 2018
Contributor
TomFinley
left a comment
TomFinley
left a comment
There was a problem hiding this comment.
Cool thanks @Ivanidzo4ka, only a few minor notes. Also mentioning @saeedmaleki as informational.
sfilipi
approved these changes
Jan 2, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1985