Add test for linear svm and polish it's code #1998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 2, 2019 14:27
TomFinley
approved these changes
Jan 2, 2019
Contributor
TomFinley
left a comment
TomFinley
left a comment
There was a problem hiding this comment.
Thank you good sir @Ivanidzo4ka !
sfilipi
reviewed
Jan 2, 2019
|
|
||
| private protected override TrainStateBase MakeState(IChannel ch, int numFeatures, LinearModelParameters predictor) | ||
| { | ||
| return new TrainState(ch, numFeatures, predictor, this); |
Member
There was a problem hiding this comment.
nit and only if you want to: change to =>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1984.