Begin hiding the IPredictorProducing #2404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomFinley
requested review from
Ivanidzo4ka,
eerhardt,
sfilipi,
shauheen and
yaeldekel
Codecov Report
@@ Coverage Diff @@
## master #2404 +/- ##
=========================================
Coverage ? 71.25%
=========================================
Files ? 785
Lines ? 140869
Branches ? 16102
=========================================
Hits ? 100381
Misses ? 36023
Partials ? 4465
|
Ivanidzo4ka
reviewed
Feb 4, 2019
Ivanidzo4ka
reviewed
Feb 4, 2019
| ConcurrentDictionary<FeatureSubsetModel<TOutput>, TOutput[]> predictions); | ||
| } | ||
|
|
||
| public delegate void SignatureEnsembleDiversityMeasure(); |
Contributor
There was a problem hiding this comment.
public [](start = 4, length = 6)
public [](start = 4, length = 6)
maybe hide it as well? #Closed
Contributor
Ivanidzo4ka
reviewed
Feb 4, 2019
src/Microsoft.ML.Ensemble/Trainer/Multiclass/EnsembleMultiClassModelParameters.cs
Show resolved
Hide resolved
Ivanidzo4ka
reviewed
Feb 4, 2019
Ivanidzo4ka
reviewed
Feb 4, 2019
test/Microsoft.ML.Tests/Scenarios/Api/CookbookSamples/CookbookSamples.cs
Show resolved
Hide resolved
wschin
reviewed
Feb 5, 2019
src/Microsoft.ML.Ensemble/Trainer/Multiclass/MulticlassDataPartitionEnsembleTrainer.cs
Outdated
Show resolved
Hide resolved
wschin
reviewed
Feb 5, 2019
* Internalize the interface IDistPredictorProducing. * Remove the two-generic IPredictor as it is unused and unusable. * Refactor much of the Ensemble code so that it uses IPredictorProducing less in its public surface.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards but not quite finishing #2251. Why not finish? At issue is that we must resolve #2378 in some fashion (TBD) before we continue, but as it is I think this is a move in the right direction. The public surface using this interface has now been reduced considerably, but of course not quite completely eliminated. So this is not a work in progress, but I didn't want to leave such a big change lying around.
First commit internalizes the (less used)
IDistPredictorProducing, while the second does some but not all of the work of internalizingIPredictorProducing.