TextLoader throws when type is missing LoadColumnAttribute #3071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssing LoadColumnAttribute
Ivanidzo4ka
approved these changes
Mar 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #3071 +/- ##
==========================================
- Coverage 72.53% 72.53% -0.01%
==========================================
Files 806 806
Lines 144282 144304 +22
Branches 16183 16188 +5
==========================================
+ Hits 104661 104674 +13
- Misses 35217 35223 +6
- Partials 4404 4407 +3
|
TomFinley
reviewed
Mar 24, 2019
|
|
||
| host.Assert(mappingAttr != null, $"Field or property {memberInfo.Name} is missing the {nameof(LoadColumnAttribute)} attribute"); | ||
| if (mappingAttr == null) | ||
| throw host.Except($"{(memberInfo is FieldInfo ? "Field" : "Property")} '{memberInfo.Name}' is missing the {nameof(LoadColumnAttribute)} attribute"); |
Contributor
There was a problem hiding this comment.
memberInfo.Name [](start = 93, length = 15)
Just a note, while we often use ' to indicate quoting of things that can contain potentially confusing items like spaces, since C# identifiers cannot contain spaces I view their presence as less essential than I would in, say, a column name or some other such entity. (Not a big deal at all, just registering a random thought since I am half allergic to letting PRs pass with no comments whatsoever. :D )
TomFinley
approved these changes
Mar 24, 2019
Contributor
TomFinley
left a comment
TomFinley
left a comment
There was a problem hiding this comment.
Thank you @yaeldekel !!
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3051.
Edit: This also fixes #2037.