Removed unused CodeGen Baseline #5172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5172 +/- ##
===========================================
+ Coverage 75.81% 88.92% +13.11%
===========================================
Files 993 237 -756
Lines 181068 43057 -138011
Branches 19494 2266 -17228
===========================================
- Hits 137271 38289 -98982
+ Misses 38507 4450 -34057
+ Partials 5290 318 -4972
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
codegen-out.csfile was supposed to be used as baseline for some test:https://github.com/dotnet/machinelearning/blob/e2f7075782764c9dab8f0a04013aaf8b9921d984/test/BaselineOutput/Common/Command/codegen-out.cs
The file was introduced in #1654 along with a
CommandCodeGen()test which used the baseline to test the MAMLcodegencommand. That test, along with the CodeGenerationUtils class (which I guess was only used by the codegen command) was deleted in #1848, but the baseline was left... so I'm assuming this was an error, and I'm simply deleting the baseline file in this PR.There is also another test,
CheckFastTreeParallelInterface(), which declaresvar csOutPath = DeleteOutputPath(outRoot, "codegen-out.cs");but actually never uses thecsOutPathvariable. Also, the test is disabled for some reason that seems unrelated to thecodegencommand. So I'm simply removing that variable. As I guess it wasn't meant to use the baseline I'm deleting anyway (notice that the baseline got introduced in #1654 as I've mentioned, but theCheckFastTreeParallelInterfacewas introduced in the first commit of the ML.NET repo, and it already had the unused variable).