-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Benchmarks created by @yaeldekel #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
More benchmarks
# Conflicts: # test/Microsoft.ML.Benchmarks/StochasticDualCoordinateAscentClassifierBench.cs
| using Microsoft.ML.Runtime.Data; | ||
| using Microsoft.ML.Runtime.FastTree; | ||
| using Microsoft.ML.Runtime.Internal.Calibration; | ||
| using Microsoft.ML.Runtime.Learners; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Learners [](start = 27, length = 8)
The changes to this file are probably not necessary. One of the tests was written here initially, but then moved to the Benchmarks project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yaeldekel good point! I have reverted this change
|
Is this a duplicate of #722? @briancylui @danmosemsft |
|
@eerhardt Seems possible to me, and I like the perf results presented above. Regarding the perf results, KMeansAndLogisticRegression (KMeans+LR) shares the same AccuracyMacro with SDCA (0.98), but since the This could be addressed either here or in #724. |
|
Sorry for the confusion, I was told yesterday that this thing needs to be finished. I did not know that @briancylui is also working on this. Closing since it's a duplicate. |
|
Thank you @adamsitnik for your time and the good work - much appreciated. |
|
No worries, @adamsitnik. Thanks for the help. |
I took the benchmarks created by @yaeldekel, solved merge conflict run them and changed the config a little bit to run just one warmup iteration.
@davidwrighton to run all the benchmarks you need to pass
*as the filer:Sample results: