Skip to content

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Sep 25, 2025

We unintentionally marked two internal classes as public. The change is to mark them back as internal.

@Copilot Copilot AI review requested due to automatic review settings September 25, 2025 23:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the access modifiers of two internal utility classes that were unintentionally marked as public, changing them back to their intended internal visibility.

  • Changes BitVector class from public to internal
  • Changes DawgBuilder class from public to internal

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, since these were added in this release we can still do this.

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.01%. Comparing base (fb39755) to head (23742b5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7511      +/-   ##
==========================================
- Coverage   69.01%   69.01%   -0.01%     
==========================================
  Files        1482     1482              
  Lines      273999   273999              
  Branches    28258    28258              
==========================================
- Hits       189093   189088       -5     
- Misses      77520    77526       +6     
+ Partials     7386     7385       -1     
Flag Coverage Δ
Debug 69.01% <ø> (-0.01%) ⬇️
production 63.30% <ø> (-0.01%) ⬇️
test 89.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/Microsoft.ML.Tokenizers/Utils/DoubleArrayTrie.cs 82.66% <ø> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tarekgh
Copy link
Member Author

tarekgh commented Sep 26, 2025

/ba-g Mac-OS unrelated failures

@tarekgh tarekgh merged commit 7c32fa6 into dotnet:main Sep 26, 2025
20 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants