Update Windows image, fix mac build #7515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Windows build image from 2019 to 2022 and fixes macOS build issues by removing workarounds and simplifying dependency installation.
- Updates Windows CI image from 1es-windows-2019 to 1es-windows-2022
- Removes obsolete macOS Homebrew workaround for python installation
- Simplifies macOS build dependency installation by removing python@3.13 installation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Official build was successful, will merge to unblock. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7515 +/- ##
==========================================
- Coverage 69.01% 69.00% -0.01%
==========================================
Files 1482 1482
Lines 274050 274050
Branches 28266 28266
==========================================
- Hits 189128 189114 -14
- Misses 77526 77538 +12
- Partials 7396 7398 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
LGTM, Thanks @ericstj |
asp2286
pushed a commit
to asp2286/machinelearning
that referenced
this pull request
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public CI doesn't test this. Will kick off official build
https://dev.azure.com/dnceng/internal/_build/results?buildId=2807210&view=results