[Dependencies] Regression when adding newly created project reference, it is always yellow even though has hierarchy

[abpiskunov]

VS Dev15.5 Preview 2 d15rel 27016.0

Repro steps (we have automated integration test and i tried them manually too):

1. Create a new core 2.0 Web app wait for restore, save solution
2. Creat a new ClassLibrary core 2.0, wait for restore
3. Add project reference web->classlib via Add Reference dialog, wait for restore:

Actual result:

Project dependency appears in the web but is yellow, However it does have hierarchy under it.

Expected dependency to be normal since targets frameworks are the same for web and classlib.

[abpiskunov]

Note: The issue is consistenly reproing for new projects. After closing and reopening solution it sometimes work somtimes still shows yellow project dependency.

[natidea]

This is being tracked by 509659
This problem is due to a change in MSBuild metadata (ResolveProjectReferences)

The reference is:

  <ItemGroup>
    <ProjectReference Include="..\ClassLibrary1\ClassLibrary1.csproj" />
  </ItemGroup>

This change breaks the check in DependenciesRuleHandlerBase.cs#L129 which compares the Original Item Specs from ProjectReference and ResolvedProjectReference to determine whether a change should be processed. It returns false and hence the design time change is not processed.