NuGet packages for rtw releases shouldn't have prerelease dependency

[genlu]

Some of our partner teams want to consume the following NuGet packages from nuget.org but have to fallback to MyGet:

1. Microsoft.VisualStudio.Editors
2. Microsoft.VisualStudio.AppDesigner

I was trying to upload those to nuget.org for 15.4 \\cpvsbuild\drops\Roslyn\Roslyn-Project-System\DotNet-Project-System-Pre15.5\20170913.1, but it turns out both of those packages have dependencies on prerelease packages that are not on nuget.org so they can't be repacked as release version:

Package 'Microsoft.VisualStudio.AppDesigner' depends on a pre-release package 'Microsoft.VisualStudio.Shell.15.0, 15.0.26507-alpha'
Package 'Microsoft.VisualStudio.AppDesigner' depends on a pre-release package 'Microsoft.VisualStudio.Shell.Design, 15.0.26507-alpha'

Package 'Microsoft.VisualStudio.Editors' depends on a pre-release package 'Microsoft.VisualStudio.AppDesigner, 15.3.0-beta2-6211301'
Package 'Microsoft.VisualStudio.Editors' depends on a pre-release package 'Microsoft.VisualStudio.Shell.15.0, 15.0.26507-alpha'

And a quick look shows that this is also the case for 15.5 \\cpvsbuild\drops\Roslyn\Roslyn-Project-System\DotNet-Project-System\20171129.1\packages:

Package 'Microsoft.VisualStudio.AppDesigner' depends on a pre-release package 'RoslynTools.Microsoft.RepoToolset, 1.0.0-alpha58'
Package 'Microsoft.VisualStudio.AppDesigner' depends on a pre-release package 'Microsoft.Net.Compilers, 2.6.0-beta3-62310-01'
Package 'Microsoft.VisualStudio.AppDesigner' depends on a pre-release package 'Microsoft.VisualStudio.DataTools.Interop, 15.0.26606-alpha'
Package 'Microsoft.VisualStudio.AppDesigner' depends on a pre-release package 'Microsoft.VisualStudio.Diagnostics.PerformanceProvider, 15.0.26606-alpha'
Package 'Microsoft.VisualStudio.AppDesigner' depends on a pre-release package 'Microsoft.VisualStudio.GraphModel, 15.0.26606-alpha'
Package 'Microsoft.VisualStudio.AppDesigner' depends on a pre-release package 'Microsoft.VisualStudio.Threading, 15.5.13-beta'
Package 'Microsoft.VisualStudio.AppDesigner' depends on a pre-release package 'Microsoft.VisualStudio.Threading.Analyzers, 15.5.13-beta'
Package 'Microsoft.VisualStudio.AppDesigner' depends on a pre-release package 'Microsoft.VisualStudio.Telemetry, 15.3.799-masterDDDBA9E4'
Package 'Microsoft.VisualStudio.AppDesigner' depends on a pre-release package 'Microsoft.VisualStudio.VSHelp, 15.0.26606-alpha'
Package 'Microsoft.VisualStudio.AppDesigner' depends on a pre-release package 'Microsoft.VisualStudio.XmlEditor, 15.0.26606-alpha'
Package 'Microsoft.VisualStudio.AppDesigner' depends on a pre-release package 'Microsoft.VSDesigner, 15.0.26606-alpha'
Package 'Microsoft.VisualStudio.AppDesigner' depends on a pre-release package 'Microsoft.VisualStudio.DataDesign.Common, 15.0.26606-alpha'
Package 'Microsoft.VisualStudio.AppDesigner' depends on a pre-release package 'VsWebSite.Interop, 8.0.0-alpha'
Package 'Microsoft.VisualStudio.AppDesigner' depends on a pre-release package 'Microsoft.VisualStudio.TemplateWizardInterface, 8.0.0-alpha'

Package 'Microsoft.VisualStudio.Editors' depends on a pre-release package 'Microsoft.VisualStudio.AppDesigner, 15.5.0-beta2-62329-01'
Package 'Microsoft.VisualStudio.Editors' depends on a pre-release package 'RoslynTools.Microsoft.RepoToolset, 1.0.0-alpha58'
Package 'Microsoft.VisualStudio.Editors' depends on a pre-release package 'Microsoft.Net.Compilers, 2.6.0-beta3-62310-01'
Package 'Microsoft.VisualStudio.Editors' depends on a pre-release package 'Microsoft.VisualStudio.DataTools.Interop, 15.0.26606-alpha'
Package 'Microsoft.VisualStudio.Editors' depends on a pre-release package 'Microsoft.VisualStudio.Diagnostics.PerformanceProvider, 15.0.26606-alpha'
Package 'Microsoft.VisualStudio.Editors' depends on a pre-release package 'Microsoft.VisualStudio.GraphModel, 15.0.26606-alpha'
Package 'Microsoft.VisualStudio.Editors' depends on a pre-release package 'Microsoft.VisualStudio.Threading, 15.5.13-beta'
Package 'Microsoft.VisualStudio.Editors' depends on a pre-release package 'Microsoft.VisualStudio.Threading.Analyzers, 15.5.13-beta'
Package 'Microsoft.VisualStudio.Editors' depends on a pre-release package 'Microsoft.VisualStudio.Telemetry, 15.3.799-masterDDDBA9E4'
Package 'Microsoft.VisualStudio.Editors' depends on a pre-release package 'Microsoft.VisualStudio.VSHelp, 15.0.26606-alpha'
Package 'Microsoft.VisualStudio.Editors' depends on a pre-release package 'Microsoft.VisualStudio.XmlEditor, 15.0.26606-alpha'
Package 'Microsoft.VisualStudio.Editors' depends on a pre-release package 'Microsoft.VSDesigner, 15.0.26606-alpha'
Package 'Microsoft.VisualStudio.Editors' depends on a pre-release package 'Microsoft.VisualStudio.LanguageServices, 2.6.0-beta1-62113-02'

To release these two packages, at least the following requirement have to be fulfilled:

1. Release packages should not depend on prerelease (build already guarantees this unless we have the check commented out)
2. Packages on nuget.org only depend on other packages on nuget.org (no myget dependencies)

[genlu]

FYI @natidea @jasonmalinowski

[davkean]

This is a chicken and egg problem; we have a dependency on a pre-release SDK that can't be released until we insert...

Also RoslynTools.Microsoft.RepoToolset, 1.0.0-alpha58/Microsoft.Net.Compilers should not end up in the dependencies list...

[genlu]

We have asked @paulvanbrenk about this again, he says the packages we published on myget will suffice for their purposes. So no need to release them now. Please feel free to close this.

[Pilchie]

Closing per above.