-
Couldn't load subscription status.
- Fork 777
Fix typos in docs #2258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix typos in docs #2258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Hi @barbaralocsi and thanks for this contribution. GitHub is blocking the merge because it doesn't think you've agreed to the Contributor License Agreement (CLA). We can't accept PRs from anyone who hasn't agreed to the CLA, because that's the only way we can ensure that we remain in compliance with copyright and licensing requirements. GitHub should have given you a link to fill in the CLA. If not, or if you have in fact done this, please let me know and I'll try to work out how to unblock this. Update: actually, I just found the other PR you submitted, and for for that one, the CLA approval bot seemed to think there is no problem. So I'm a bit confused, but in any case, if you could let me know whether a) GitHub is suggestion any action required to you for the PR and b) whether you believe you have agreed to the CLA. |
|
Hi @idg10, I don't see any required actions. But I am not sure that I am looking at the right place. Or would it be obvious if it's there? I did agree a CLA when I contributed to microsoft/playwright a few years ago, but I am not sure if that's the same CLA. On https://opensource.microsoft.com/cla/ it says the .NET Foundation CLA is separate. I don't remember accepting other CLAs. What I know for sure is different between my 2 PRs (#2251, #2258) is this:
|
|
OK...so I've reached out to the .NET Foundation's support team to try and work out what's happening. But it may well be the email address thing. If you don't want to wait for the .NET Foundation support people to get to this, I guess you could try creating a new branch with the same change but the right email, and create another PR. But I'm happy to wait and see if the .NET Foundation people can fix it if you prefer. |
|
Another interesting thing I just realised is that I accepted the Microsoft CLA back in 2022.10.11. |
No description provided.