Fix compiler directive in ImmutableListTest #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is visible to the test assembly, which is exactly when it is signed (and not vice versa). The SIGNED-directive is thus added to the Uwp-DeviceRunner project.
Collaborator
Author
Collaborator
|
I have no idea what this supposed to be. Why not test it always? |
Collaborator
Author
|
Because the Android-Testrunner cannot be signed (#484) |
Collaborator
|
Still, why not run this particular test always? |
Collaborator
Author
|
Because ImmutableList is internal and must be declared visible to the test assembly which, in turn, must be signed. |
Collaborator
Author
|
See InternalsVisibleTo.cs |
Collaborator
|
I leave this up to you, I have practically no undestanding of the underlying infrastructure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code should be tested when System.Reactive is visible to the test assembly which is exactly when it is signed (and not vice versa). The SIGNED-directive is thus added to the Uwp-DeviceRunner project.