Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SourceLink] Use PEReader to try to read pdbs #57417

Closed
davidwengier opened this issue Oct 27, 2021 · 1 comment · Fixed by #57537
Closed

[SourceLink] Use PEReader to try to read pdbs #57417

davidwengier opened this issue Oct 27, 2021 · 1 comment · Fixed by #57537
Assignees
@davidwengier
Labels
Navigation-SourceLink Metadata as Source, SourceLink, Decompilation untriaged Issues and PRs which have not yet been triaged by a lead

Comments

@davidwengier
Copy link
Contributor

We should be checking that the PDB version matches the DLL when we find the .pdb file next to the .dll.

The easiest way to handle both cases (including the embedded PBD) is to use PEReader.TryOpenAssociatedPortablePdb method: https://source.dot.net/#System.Reflection.Metadata/System/Reflection/PortableExecutable/PEReader.cs,d04ae6c22fdcad8f,references

Originally posted by @tmat in #57073 (comment)
@davidwengier davidwengier added the Navigation-SourceLink Metadata as Source, SourceLink, Decompilation label Oct 27, 2021
@davidwengier davidwengier self-assigned this Oct 27, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Oct 27, 2021
This was referenced Oct 27, 2021
Open
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwengier davidwengier

Labels
Navigation-SourceLink Metadata as Source, SourceLink, Decompilation untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify PDB reading code davidwengier/roslyn
1 participant
@davidwengier