Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-work AutomationObject design #61855

Closed
Youssef1313 opened this issue Jun 13, 2022 · 1 comment
Closed

Re-work AutomationObject design #61855

Youssef1313 opened this issue Jun 13, 2022 · 1 comment
Assignees
@tmat
Labels
Area-IDE Concept-Continuous Improvement
Milestone
17.6 P3

Comments

@Youssef1313
Copy link
Member

  • https://github.com/dotnet/roslyn/blob/main/src/VisualStudio/CSharp/Impl/Options/AutomationObject/AutomationObject.ObsoleteAndUnused.cs

    I think this can be deleted. While there is a comment saying they're kept for backcompat. My tests shows that backcompat isn't affected by deletion. I confirmed this by exporting my current VS settings, manually modify the file by renaming an element to a name AutomationObject don't know about, then importing the settings again. No crash happened.

  • AutomationObject can get outdated easily (missing options), and get unintentionally filled with editorconfig-only code-style options (extra unnecessary options). A source generator may be a good solution to this. A unit test approach may also be worth investigating (will likely be reflection-based).
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 13, 2022
@vatsalyaagrawal vatsalyaagrawal removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jul 8, 2022
@vatsalyaagrawal vatsalyaagrawal added this to the 17.4 milestone Jul 8, 2022
@arunchndr arunchndr modified the milestones: 17.4, 17.6 P3 Jan 17, 2023
@CyrusNajmabadi
Copy link
Member

Closing out as speculative.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmat tmat

Labels
Area-IDE Concept-Continuous Improvement
Projects
None yet
Milestone
17.6 P3
Development

No branches or pull requests
5 participants
@tmat @CyrusNajmabadi @vatsalyaagrawal @Youssef1313 @arunchndr