Merge recent future into generators #11270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to support this, I added a way to set different default value per language
it looks like my previous update 2 leak fix for Task introduced argId leaks. since this was much smaller leak than before I didn't notice it being leaked.
fixed live diagnostic argId leak
turn off csharp full solution analysis.
Revert "turn off csharp full solution analysis."
… so that we handle ServiceFeatureOnOffOptions.OptionName separately.
…instead of integer
Turn off full solution analysis by default for C#
Calling TestUtilities.InitUtilities from within the library, instead of a csx file, will result in the path of the file where the library was initially built to be passed to InitUtilities which is not the expected behavior. Fixing it in all occurence Also removing some unnecessary and unused helpers
Since this file wasn't being included in the VSIX, it was having no effect. We're better off using CodeBase attributes anyways which apply earlier in the assembly resolution process.
This is correctly bundled along with the language services VSIX, which is the place it should ship with. We already take a VSIX dependency upon that VSIX.
This is a DLL that doesn't ship and isn't used for anything other than pkgdef generation.
…of-testsetup Change contents of the TestSetup project
While installing the VSIXes using the install_vsixes.csx, uninstall the previous VSIXes before installing the new ones.
Call TestUtilities.InitUtilities appropriately
uninstall previous vsixes
Check for Directory.Exists before deleting
…h's, while's, do-while's, and using's.
One TempDirectory For all tests
Fixed typo in field name
…nt-and-project-specific-options Add API for consuming solution and document-specific options
we used to create all solution crawler analyzers lazily. which means all analyzers only register themselves once the very first solution crawler pass has run. this caused ctrl+. for LB right after solution open sometimes not work since solution crawler didn't run its first pass yet so there is no analyzers registered to system. now, we create solution crawler analyzers for active files non-lazily. those analyzers should be ready right away once solution is up.
create active file analyzers non-lazily.
dotnet#11151) Previouly we assumed that the type parameters in a method would not be of the same TypeSymbol when generating a method and put them in a dictionary. This causes exceptions when attempting to add to the dictionary and the TypeSymbol is already added as a key. Now we use a list of instead of a dictionary. Fixes dotnet#10004
Adds an analyzer/codefix for adding missing braces Fixes dotnet#10942
Switch to straight metadata reading to build our metadata indices for add-using and add-reference.
Add null checks before raising events. Fixes [217660](https://devdiv.visualstudio.com/DevDiv/_workitems?_a=edit&id=217660&triage=true)
Fix edge cases typing Enter before /**/ comments.
…-future20160511-150020 Conflicts: src/Compilers/Core/Portable/PublicAPI.Unshipped.txt src/EditorFeatures/CSharpTest/Diagnostics/GenerateMethod/GenerateMethodTests.cs src/Features/Core/Portable/Diagnostics/DefaultDiagnosticAnalyzerService.cs src/Features/Core/Portable/Diagnostics/DiagnosticAnalyzerService_IncrementalAnalyzer.cs src/Workspaces/Core/Portable/Workspaces.csproj
…20160511-150020 Merge master into future
|
@dotnet/roslyn-compiler - FYI. Merging from future ---> features/generators |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.