-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge the feature 'throw expressions' into master #13750
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And other changes per code review.
Implementation of "throw" expressions
gafter
added
Area-Compilers
Feature Request
New Language Feature - Throw Expression
Throw Expression
labels
Sep 12, 2016
gafter
force-pushed
the
features/throwexpr
branch
from
September 13, 2016 18:01
c1cbc6f
to
2ec37fb
Compare
Yes, I believe I reviewed this before. LGTM |
@jaredpar Does this look good to you for integration today? |
jaredpar
approved these changes
Sep 19, 2016
Merge master into features/throwexpr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4 - In Review
A fix for the issue is submitted for review.
Area-Compilers
cla-already-signed
Feature Request
New Language Feature - Throw Expression
Throw Expression
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed merge of 'throw expressions' into master.
The implementation was previously reviewed twice - once in features/patterns, once in features/throwexpr.
Fixes #13745.
See here for all known open issues.
@dotnet/roslyn-compiler Please review for merge into master.