Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the feature 'throw expressions' into master #13750

Merged
merged 9 commits into from
Sep 20, 2016
Merged

Conversation

gafter
Copy link
Member

@gafter gafter commented Sep 12, 2016

This is a proposed merge of 'throw expressions' into master.
The implementation was previously reviewed twice - once in features/patterns, once in features/throwexpr.
Fixes #13745.
See here for all known open issues.

@dotnet/roslyn-compiler Please review for merge into master.

@gafter gafter added this to the 2.0 (RC) milestone Sep 12, 2016
@gafter gafter self-assigned this Sep 12, 2016
@gafter gafter added the 4 - In Review A fix for the issue is submitted for review. label Sep 12, 2016
@gafter
Copy link
Member Author

gafter commented Sep 13, 2016

@agocke @jaredpar I need an approval, please, to merge this previously-reviewed code into master.

@agocke
Copy link
Member

agocke commented Sep 13, 2016

Yes, I believe I reviewed this before. LGTM

@gafter
Copy link
Member Author

gafter commented Sep 19, 2016

@jaredpar Does this look good to you for integration today?

@gafter gafter closed this Sep 20, 2016
@gafter gafter reopened this Sep 20, 2016
@gafter gafter merged commit d710efa into master Sep 20, 2016
@jaredpar jaredpar deleted the features/throwexpr branch February 15, 2017 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants