Run Naming Rules on parameters #16317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpoeschl
force-pushed
the
NamingRulesForParameters
branch
from
6332980
to
bb30e5b
Compare
|
Tagging for review @dotnet/roslyn-ide @jmarolf |
jmarolf
approved these changes
Jan 9, 2017
Pilchie
approved these changes
Jan 9, 2017
|
@jmarolf said he pulled the changes down and did some testing locally as well. |
|
Tagging @MattGertz for RC.3 Escrow consideration. |
|
This was rejected for RC.3, but approved for RTW. Can you retarget to |
|
@Pilchie retargeted to |
|
Yes. Please do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13249
Ask Mode
Customer scenario: Customers cannot create naming rules that target parameters.
Bugs this fixes: #13249
Workarounds, if any: None
Risk: Low. However, this utilizes a new feature of RegisterSymbolAction that allows it to work on parameters (#13931), and this new feature has not been used much to this point.
Performance impact: Low, but non-zero. The naming style analyzer will now process more symbols (all parameters), and processing a symbol does require some allocations, though @CyrusNajmabadi did a pass to decrease the number of allocations per analyzed symbol in #15972.
Is this a regression from a previous update?: No
Root cause analysis:
RegisterSymbolActiondid not support parameters until #13931, so we could not support parameters when this feature was first checked in.How was the bug found? It was just a known missing piece of Naming Styles. Not reported by anyone as far as I can tell.