Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InlineParameterNameHints: Support record base type #47834

Merged
merged 5 commits into from
Sep 22, 2020
Merged

InlineParameterNameHints: Support record base type #47834

merged 5 commits into from
Sep 22, 2020

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Sep 18, 2020 •
edited
Loading

Fixes #47696

@Youssef1313 Youssef1313 requested a review from a team as a code owner September 18, 2020 15:02
@Youssef1313 Youssef1313 marked this pull request as draft September 18, 2020 15:02
@Youssef1313 Youssef1313 marked this pull request as ready for review September 18, 2020 15:48
@Youssef1313 Youssef1313 changed the title Draft: InlineParameterNameHints: Support record base type InlineParameterNameHints: Support record base type Sep 18, 2020
@jinujoseph jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Sep 18, 2020
@Youssef1313 Youssef1313 marked this pull request as draft September 19, 2020 12:17
@Youssef1313 Youssef1313 marked this pull request as ready for review September 19, 2020 12:17
@Youssef1313 Youssef1313 marked this pull request as draft September 19, 2020 14:51
@Youssef1313 Youssef1313 marked this pull request as ready for review September 19, 2020 14:51
This was referenced Sep 21, 2020
Closed
Closed
CyrusNajmabadi
CyrusNajmabadi approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CyrusNajmabadi CyrusNajmabadi merged commit ecf0968 into dotnet:master Sep 22, 2020
@ghost ghost added this to the Next milestone Sep 22, 2020
@Youssef1313 Youssef1313 deleted the patch-10 branch September 22, 2020 21:39
@Cosifne Cosifne modified the milestones: Next, 16.9.P1 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees

@CyrusNajmabadi CyrusNajmabadi

Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
16.9.P1
Development

Successfully merging this pull request may close these issues.

InlineParameterNameHints: add support for record base type
5 participants
@Youssef1313 @jasonmalinowski @CyrusNajmabadi @jinujoseph @Cosifne