Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve lexer error recovery with interpolated strings. #54875

Merged
merged 49 commits into from
Jul 25, 2021
Merged

Improve lexer error recovery with interpolated strings. #54875

merged 49 commits into from
Jul 25, 2021

Commits on Jul 16, 2021

  1. Improve lexing recovery in string literals.

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    90a4f3b View commit details
    Browse the repository at this point in the history

  2. add tests

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    944eff3 View commit details
    Browse the repository at this point in the history

  3. Improved recovery for comments in strings.

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    4a25d56 View commit details
    Browse the repository at this point in the history

  4. Add tests

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    1ea60b1 View commit details
    Browse the repository at this point in the history

  5. Update tests

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    b1874f7 View commit details
    Browse the repository at this point in the history

  6. Improve recovery

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    804dc44 View commit details
    Browse the repository at this point in the history

  7. Remove hardcoded error codes.

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    f19a2fc View commit details
    Browse the repository at this point in the history

  8. Doc

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    a8c2379 View commit details
    Browse the repository at this point in the history

  9. Before changes

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    649f71b View commit details
    Browse the repository at this point in the history

  10. Collapse to one error message

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    d985d20 View commit details
    Browse the repository at this point in the history

  11. Simplify

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    a0d79d5 View commit details
    Browse the repository at this point in the history

  12. Fixup

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    1a26596 View commit details
    Browse the repository at this point in the history

  13. Temp

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    f789b07 View commit details
    Browse the repository at this point in the history

  14. Feature fallout

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    0ab8e6d View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. Merge remote-tracking branch 'upstream/main' into lexingRecovery

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    c1cc28c View commit details
    Browse the repository at this point in the history

  2. Spelling

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    7bb1203 View commit details
    Browse the repository at this point in the history

  3. Update error code

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    db131e6 View commit details
    Browse the repository at this point in the history

  4. spelling

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    4d9b049 View commit details
    Browse the repository at this point in the history

  5. nrt

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    929bb68 View commit details
    Browse the repository at this point in the history

  6. Be consistent with brace placement

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    8e1dbdc View commit details
    Browse the repository at this point in the history

  7. Use ??=

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    17888b0 View commit details
    Browse the repository at this point in the history

  8. Use discards

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    e213d0c View commit details
    Browse the repository at this point in the history

  9. use pattern matching

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    0e7a783 View commit details
    Browse the repository at this point in the history

  10. improve error test

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    6663af9 View commit details
    Browse the repository at this point in the history

  11. Pattern matching

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    50782d0 View commit details
    Browse the repository at this point in the history

  12. Named parameters for clarity

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    1ef5ae1 View commit details
    Browse the repository at this point in the history

  13. no need for 'this._'

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    31c520f View commit details
    Browse the repository at this point in the history

  14. Fix spelling

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    54edb98 View commit details
    Browse the repository at this point in the history

  15. Fix tests

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    3ce7485 View commit details
    Browse the repository at this point in the history

  16. Update test

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    b58beed View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. Rename error code

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    2cf9b05 View commit details
    Browse the repository at this point in the history

  2. update resource

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    e6eca49 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. Add braces

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    50075eb View commit details
    Browse the repository at this point in the history

  2. add named args

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    3397aec View commit details
    Browse the repository at this point in the history

  3. Update comment

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    a4b6282 View commit details
    Browse the repository at this point in the history

  4. Update tests

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    8894311 View commit details
    Browse the repository at this point in the history

  5. Update tests

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    d2b4a31 View commit details
    Browse the repository at this point in the history

  6. NRTenable

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    90e87ca View commit details
    Browse the repository at this point in the history

  7. Tweak how we do errors.

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    59e158d View commit details
    Browse the repository at this point in the history

  8. nrt

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    7429a21 View commit details
    Browse the repository at this point in the history

  9. Always pick the earliest error

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    7388648 View commit details
    Browse the repository at this point in the history

  10. Change code

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    e8364d0 View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'upstream/main' into lexingRecovery

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    2a9e289 View commit details
    Browse the repository at this point in the history

  12. Go back to old behavior

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    7e3d7fb View commit details
    Browse the repository at this point in the history

  13. Update tests

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    04886a5 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2021

  1. Merge remote-tracking branch 'upstream/main' into lexingRecovery

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    136a6fc View commit details
    Browse the repository at this point in the history

  2. Fix test

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    27be66d View commit details
    Browse the repository at this point in the history

  3. Adjust test baseline for `CSharpAddMissingUsingsOnPaste.VerifyDisable… 

    …dWithNull`
    @jcouv
    jcouv authored Jul 25, 2021
    Configuration menu
    Copy the full SHA
    a0e35ea View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/devjcouvintegration-test' into… 

    … lexingRecovery
    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    534a42a View commit details
    Browse the repository at this point in the history