IDE0028: Added simplifying collection initializer in tuple #72332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
victor-pogor
force-pushed
the
72169-use-collection-expression-in-valuetuple
branch
from
855d9b1
to
363d730
Compare
victor-pogor
commented
Feb 29, 2024
| if (newExpression.IsKind(SyntaxKind.TupleExpression) && | ||
| this.SpeculativeSemanticModel.GetConversion(newExpression).IsTupleLiteralConversion) | ||
| { | ||
| return true; |
There was a problem hiding this comment.
Is there any extra condition needed here? Like:
SymbolsAreCompatible(originalTypeInfo.Type, newTypeInfo.ConvertedType)I see the tests are working too if having this extra condition
There was a problem hiding this comment.
Yes. The types should be validated as well.
|
Hi @CyrusNajmabadi, could you review this PR please 🌝 |
CyrusNajmabadi
approved these changes
Mar 27, 2024
|
Thanks! |
…n-expression-in-valuetuple
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #72169
collection-expression.mp4