Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnC: workaround for empty display class #73366

Merged

Conversation

tmat
Copy link
Member

@tmat tmat commented May 7, 2024

Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2034515.

It is currently unclear how this condition may occur, so don't have any test to cover it.
Follow up: #73365

@tmat tmat requested a review from a team as a code owner May 7, 2024 16:28
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels May 7, 2024
@tmat
Copy link
Member Author

tmat commented May 7, 2024

@cston @davidwengier ptal

@tmat tmat changed the base branch from main to release/dev17.10 May 7, 2024 16:28
@tmat
Copy link
Member Author

tmat commented May 7, 2024

@jjonescz ptal

@jaredpar
Copy link
Member

jaredpar commented May 8, 2024

@RikkiGibson PTAL

@RikkiGibson RikkiGibson self-assigned this May 8, 2024
Copy link
Contributor

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's def make sure to add the test when we figure out what is causing this.

@tmat tmat merged commit 8b7d080 into dotnet:release/dev17.10 May 9, 2024
24 checks passed
@tmat tmat deleted the EmptyDisplayClassWorkaround17.10 branch May 9, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants