Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent IDE0290 (convert to primary constructor) in ref struct #73869

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Prevent IDE0290 (convert to primary constructor) in ref struct #73869

merged 4 commits into from
Sep 26, 2024

Conversation

GiovanniBraconi
Copy link
Contributor

@GiovanniBraconi GiovanniBraconi commented Jun 6, 2024 •
edited
Loading

Fixes #73614

@GiovanniBraconi GiovanniBraconi requested a review from a team as a code owner June 6, 2024 10:18
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jun 6, 2024
@build-analysis build-analysis bot mentioned this pull request Jun 6, 2024
Open
3 tasks
@CyrusNajmabadi
Copy link
Member

Hi, could you not force-push :) It breaks the code flow process. THanks!

Feel free to squash merge at the end if you want though.

CyrusNajmabadi
CyrusNajmabadi approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary sign-off, with request to just change the comment. Thanks!

@CyrusNajmabadi
Copy link
Member

AWesome. Thanks so much for the contribution. Hope to work with you more in the future! :)

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge (squash) June 6, 2024 18:13
@CyrusNajmabadi CyrusNajmabadi merged commit 3414f2b into dotnet:main Sep 26, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Sep 26, 2024
@CyrusNajmabadi
Copy link
Member

Thanks!

This was referenced Oct 1, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Oct 11, 2024
Closed
@akhera99 akhera99 modified the milestones: Next, 17.13 P1 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.13 P1
Development

Successfully merging this pull request may close these issues.

IDE0290 code fix is invalid in ref struct
3 participants
@GiovanniBraconi @CyrusNajmabadi @akhera99