-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assertion failed '!inTry || ((unsigned)(add->acdTryIndex - 1) != XTnum)' during 'Remove empty finally 2' #110346
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
blocking-outerloop
Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs
in-pr
There is an active PR which will close this issue when it is merged
Milestone
Comments
MichalStrehovsky
added
the
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Dec 3, 2024
dotnet-policy-service
bot
added
the
untriaged
New issue has not been triaged by the area owner
label
Dec 3, 2024
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
It almost certainly is related. |
If we remove a non-enclosing region we're not getting the ACD updates right.
In this case we're removing EH#1 as the try can't throw. ACD1 is enclosed in H0 and T1; when we remove T1 we need to move ACD1 to H0 and (no enclosing try). |
AndyAyersMS
added a commit
to AndyAyersMS/runtime
that referenced
this issue
Dec 3, 2024
When an EH region is removed, the JIT must make suitable updates to any existing AddCodeDescs (ACDs). We were missing logic for the case where the removed region was not the enclosing region of the ACD. Fixes dotnet#110346. We still need to adjust the try/handler index
dotnet-policy-service
bot
added
the
in-pr
There is an active PR which will close this issue when it is merged
label
Dec 3, 2024
amanasifkhalid
added
blocking-outerloop
Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs
and removed
untriaged
New issue has not been triaged by the area owner
labels
Dec 4, 2024
AndyAyersMS
added a commit
that referenced
this issue
Dec 4, 2024
When an EH region is removed, the JIT must make suitable updates to any existing AddCodeDescs (ACDs). We were missing logic for the case where the removed region was not the enclosing region of the ACD. Fixes #110346.
eduardo-vp
pushed a commit
to eduardo-vp/runtime
that referenced
this issue
Dec 5, 2024
…t#110374) When an EH region is removed, the JIT must make suitable updates to any existing AddCodeDescs (ACDs). We were missing logic for the case where the removed region was not the enclosing region of the ACD. Fixes dotnet#110346.
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this issue
Dec 10, 2024
…t#110374) When an EH region is removed, the JIT must make suitable updates to any existing AddCodeDescs (ACDs). We were missing logic for the case where the removed region was not the enclosing region of the ACD. Fixes dotnet#110346.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
blocking-outerloop
Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs
in-pr
There is an active PR which will close this issue when it is merged
Seeing these failures in native AOT outerloop run at #110238.
Cc @AndyAyersMS in case this is related to #110273
The text was updated successfully, but these errors were encountered: