JIT: Fix ACD updates when a non-enclosing EH region is removed #110374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an EH region is removed, the JIT must make suitable updates to any existing AddCodeDescs (ACDs). We were missing logic for the case where the removed region was not the enclosing region of the ACD. Fixes dotnet#110346. We still need to adjust the try/handler index
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@amanasifkhalid can you PTAL A few more details here: #110346 (comment) |
amanasifkhalid
approved these changes
Dec 3, 2024
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
eduardo-vp
pushed a commit
to eduardo-vp/runtime
that referenced
this pull request
Dec 5, 2024
…t#110374) When an EH region is removed, the JIT must make suitable updates to any existing AddCodeDescs (ACDs). We were missing logic for the case where the removed region was not the enclosing region of the ACD. Fixes dotnet#110346.
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
…t#110374) When an EH region is removed, the JIT must make suitable updates to any existing AddCodeDescs (ACDs). We were missing logic for the case where the removed region was not the enclosing region of the ACD. Fixes dotnet#110346.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an EH region is removed, the JIT must make suitable updates to any existing AddCodeDescs (ACDs). We were missing logic for the case where the removed region was not the enclosing region of the ACD.
Fixes #110346.