Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-staging] Suppress IL3050 warnings in ILLink tests #110340

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Dec 2, 2024

The ILLink Roslyn analyzer tests have been broken in release/9.0-staging since #108482.

This was fixed in main with f94b112, so backporting that fix to .NET 9 (this is a test-only change). #108757 (comment) has context on why this was failing.

@sbomer sbomer requested review from carlossanlop, MichalStrehovsky and a team December 2, 2024 23:54
@sbomer sbomer requested a review from marek-safar as a code owner December 2, 2024 23:54
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 2, 2024
@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Dec 2, 2024
@carlossanlop carlossanlop added Servicing-approved Approved for servicing release area-Tools-ILLink .NET linker development as well as trimming analyzers and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Dec 3, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/illink
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell mode. Approved.
LGTM assuming CI is green.

@sbomer sbomer merged commit 87916ee into dotnet:release/9.0-staging Dec 3, 2024
79 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants