-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add support for reading the extern alias #11451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for reading the extern alias #11451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions. I think it is good in general. also + @dsplaisted in case you find something.
And the test will not pass until the insertion is in?
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeHaveAPackageReferenceWithAliases.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeHaveAPackageReferenceWithAliases.cs
Show resolved
Hide resolved
76bcbbe
to
16de953
Compare
Now that the NuGet dependency has been merged, do I need to rebase to run the tests with the updated NuGet, or is kicking the build off again sufficient? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I believe that kicking off the build again (which I've done) should be sufficient |
Failed with a compile error :( |
619425f
to
9cd5885
Compare
Squashed my commits into 1 to retrigger the CI. I'll rebase if it fails with a compile error again. |
9cd5885
to
fcf4d75
Compare
fcf4d75
to
d06ac71
Compare
@nkolev92 Is this ready to merge? It looks like tests are failing on .NET Framework only. If it's an issue where VS hasn't been updated with some functionality this feature needs, then you can use the RequiresMSBuildVersion Fact and Theory attributes to skip the test on full framework for now. |
I had to do some printf debugging to get that error message on the CI :) Let me fix that now @dsplaisted! Thanks for the pointer. |
Pushed again. |
@nkolev92 If those tests are eventually supposed to work on Full MSBuild, it would be preferrable to use RequiresMSBuildVersionFacts. |
5cef742
to
e82c23f
Compare
@dsplaisted Fixed. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Should be good now. |
Fixes #10947
Add support for reading the aliases flag from the assets file.
Note that this requires a NuGet insertion which has not happened yet.
cc @wli3
I want to port this eventually to a 3.1.x.