add support for reading the extern alias in 3.1.4xx #11954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for reading the aliases flag from the assets file.
wli3
reviewed
Jun 10, 2020
| [CoreMSBuildOnlyFact] | ||
| public void CanBuildProjectWithPackageReferencesWithConflictingTypes() | ||
| { | ||
| var targetFramework = "netcoreapp5.0"; |
wli3
approved these changes
Jun 11, 2020
|
@nkolev92 do you have QB approval? Once you get that you can merge |
|
@wli3 I have not done that, but I can certainly try to get it. |
|
@nkolev92 my bad. It is M2 approval. |
|
@dondrake could you approve this checkin to SDK? |
|
@wil3, sorry, wrong person... |
|
welp :D I think this is the right one @ :) |
|
@wli3 |
|
Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11612
Porting #11451 and 7a05b62 to match the change made on the legacy package reference side which added support for extern alias in 16.7, see dotnet/NuGet.BuildTasks@286d99e.
I imagine, I might have to port 40256fc
to get the tests running under the correct conditions, but just wanted to get the PR going ASAP.
cc @wli3 @dsplaisted @sfoslund