Add RequiresMSBuildVersion test attribute #11700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsplaisted
reviewed
May 20, 2020
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToReferenceAProject.cs
Outdated
Show resolved
Hide resolved
| { | ||
| public RequiresMSBuildVersionFactAttribute(string version) | ||
| { | ||
| if (!Version.TryParse(TestContext.Current.ToolsetUnderTest.MSBuildVersion, out Version msbuildVersion)) |
There was a problem hiding this comment.
I think these attributes should never skip if running on .NET Core (if we don't have the required MSBuild version in the .NET SDK, then we wouldn't be writing the test at all). If running on full framework, then we need to shell out to msbuild instead of dotnet msbuild to get the full framework MSBuild version. Also, make sure that we handle 3 versus 4 part version numbers correctly (where the required version is 3 parts and the msbuild version is 4 parts).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11369