Use forward slash as dir separator inside RelativePath #12814
Conversation
| <!-- Copy satellite assemblies. --> | ||
| <ResolvedFileToPublish Include="@(IntermediateSatelliteAssembliesWithTargetPath)"> | ||
| <RelativePath>%(IntermediateSatelliteAssembliesWithTargetPath.Culture)\%(Filename)%(Extension)</RelativePath> | ||
| <RelativePath>%(IntermediateSatelliteAssembliesWithTargetPath.Culture)/%(Filename)%(Extension)</RelativePath> |
There was a problem hiding this comment.
Will this work on windows? It seemed like the bundler was treating this as a string, causing \ to be part of a filename on unix, so I naiively would have expected this to just move the problem to windows.
There was a problem hiding this comment.
AFAIK / is a reserved character in Windows and cannot be used for naming filenames/folders. This wouldn't be the only place where we use slashes for dir separators.
There was a problem hiding this comment.
Couldn't any other custom Target use backslash, and then it would be broken as well?
There was a problem hiding this comment.
|
MSBuild can tolerate both slashes. Which component throw up on the bad slash? |
Right. The problem is really in the Bundler, which isn't smart about relative paths that use a backslash and ends up embedding satellite assemblies (and any other files which are passed to it through the SDK and contain backslashes) as if these were files named |
4 participants
Related to dotnet/runtime#37208. Using a backslash as a directory separator for copied satellite assemblies is causing errors when generating bundles for single file apps, since it's completely valid to use
\in a filename. Changing this line seemed like the easiest way to solve this.