Adding templates for C# Classlibrary, VB Consoleapp\classlibrary #130

srivatsn · 2016-09-07T20:55:29Z

Added a C# classlibrary template
Created a VB template VSIX which has templates for consoleapp\classlibrary.
Upgraded VSIX projects to Dev15 and removed them from the core-SDK.sln (which still opens in Dev14).
Added language specific props and targets
VB compiler outputs an exe when outputtype is exe even if the output path is a dll. This needs to be fixed with a new switch in the compiler but for now changing the extension post compile.
Using VBCore (VBRuntime=Embed) to not introduce new dependencies.

@dotnet/project-system @eerhardt @livarcocc @brthor

Also fixes #107

…015.

natidea · 2016-09-07T22:07:18Z

src/Tasks/Microsoft.NETCore.Build.Tasks/build/netstandard1.0/Microsoft.NETCore.Sdk.CSharp.props

+
+  <PropertyGroup>
+    <WarningLevel>4</WarningLevel>
+    <NoWarn>$(NoWarn);1701</NoWarn>


$(NoWarn);1701 [](start = 12, length = 14)

Issue #107, this arrangement seems to be adding an extra semicolon to the Suppress warnings dialog box. @davkean suggests replacing with <NoWarn>1701</NoWarn>

natidea · 2016-09-08T02:03:19Z

src/Templates/ProjectTemplates/CSharp/.NETCore/ClassLibrary/ClassLibrary.vstemplate

+    <Icon>ClassLibrary.png</Icon>
+    <ProjectType>CSharp</ProjectType>
+    <RequiredFrameworkVersion>2.0</RequiredFrameworkVersion>
+    <SortOrder>1</SortOrder>


1 [](start = 4, length = 24)

Not sure how we determine Sort Order, but this should be similar to the ConsoleApplication (currently 12). Ditto the two VB templates

Made it 21 so that it comes after the desktop class library template.

natidea · 2016-09-08T02:11:18Z

eerhardt · 2016-09-08T13:31:13Z

...Microsoft.NETCore.Build.Tasks/build/netstandard1.0/Microsoft.NETCore.Sdk.VisualBasic.targets

+<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+
+  <!--
+    TODO: The VB compiler outputs foo.dll.exe when the output type is Exe even when we pass in /o:foo.dll. 


Can we log a bug for this so it is tracked? And then add a reference to the bug here.

eerhardt · 2016-09-08T13:35:26Z

class Class1

I think this should have a namespace, and the class should be marked "public".

Here's the template we have in the CLI today:

using System;

namespace ClassLibrary
{
    public class Class1
    {
        public void Method1()
        {    
        }
    }
}

Refers to: src/Templates/ProjectTemplates/CSharp/.NETCore/ClassLibrary/Class1.cs:1 in 88d9050. [](commit_id = 88d9050, deletion_comment = False)

eerhardt · 2016-09-08T13:36:24Z

src/Templates/ProjectTemplates/CSharp/.NETCore/ClassLibrary/project-json-template.json

@@ -0,0 +1,10 @@
+{
+  "dependencies": {
+    "NETStandard.Library": "1.3",


I don't think this version exists.

https://www.nuget.org/packages/NETStandard.Library/

blackdwarf · 2016-09-08T14:48:08Z

@eerhardt namespaces can be omitted for single-file samples. However, for class libs, the class should be marked public I think. For console apps, Program class should not be public.

eerhardt · 2016-09-08T15:15:01Z

@eerhardt namespaces can be omitted for single-file samples.

This isn't a sample. It is our template for building class libraries. And I don't think we want to give the impression that we are discouraging class libraries from using namespaces. (Unless that is the impression we want to give - in which case that is news to me.)

blackdwarf · 2016-09-08T15:20:11Z

@eerhardt was news to me as well. :) However, you are right, for a class library namespace makes a lot more sense than for a console app.

…escription, icon and sort order.

srivatsn · 2016-09-08T17:25:51Z

I've added the namespace for the C# class library template. VB types are implicitly under the default namespace and so we don't put explicit namespaces in the templates.

…generates the targets\props that match the project name

srivatsn · 2016-09-08T19:33:07Z

@dotnet-bot test this please

srivatsn · 2016-09-08T20:06:57Z

@dotnet-bot test this please

srivatsn · 2016-09-08T20:38:21Z

I keep getting failures because the workspace failed to cleaned up:

ERROR: [WS-CLEANUP] Cannot delete workspace: remote file operation failed: D:\j\workspace\release_windo---dfb4e122 at hudson.remoting.Channel@2858d3ac:Azure0908111430: java.nio.file.AccessDeniedException: D:\j\workspace\release_windo---dfb4e122\packages\microsoft.vssdk.buildtools\15.0.25604-preview4\tools\vssdk\Microsoft.VsSDK.Build.Tasks.dll

Anyone run into this before?

srivatsn · 2016-09-08T20:58:25Z

@dotnet-bot test this please

eerhardt · 2016-09-08T21:07:08Z

keep getting failures because the workspace failed to cleaned up:
ERROR: [WS-CLEANUP] Cannot delete workspace: remote file operation failed: D:\j\workspace\release_windo---dfb4e122 at hudson.remoting.Channel@2858d3a:Azure0908111430: java.nio.file.AccessDeniedException: D:\j\workspace\release_windo---dfb4e122\packages\microsoft.vssdk.buildtools\15.0.25604-preview4\tools\vssdk\Microsoft.VsSDK.Build.Tasks.dll

@mmitche

mmitche · 2016-09-08T21:55:10Z

@dotnet-bot test Windows_NT Release

mmitche · 2016-09-08T21:55:28Z

@eerhardt Are you guys passing /nr:false to msbuild?

mmitche · 2016-09-08T22:53:44Z

@dotnet-bot test Windows_NT Release

eerhardt · 2016-09-09T01:52:24Z

@eerhardt Are you guys passing /nr:false to msbuild?

Not that I can see:

https://github.com/dotnet/sdk/blob/master/build.ps1#L62-L78

I didn't even know what that did until you asked and I had to look it up.

Adding templates for C# Classlibrary, VB Consoleapp\classlibrary

* update urls for in-repo stuff * Documentation cleanup * finish CHECKLIST.md * Update DEVGUIDE.md Co-authored-by: Rainer Sigwald <raines@microsoft.com> * Update README.md Co-authored-by: Rainer Sigwald <raines@microsoft.com> Co-authored-by: Rainer Sigwald <raines@microsoft.com>

srivatsn added 14 commits August 29, 2016 23:15

Add class library template

ed9e3a7

Adding class library template to the solution.

b5f3e67

Update guid for Classlibrary project

6f2311b

Add VB Console app template.

47d3324

Add a VB templates setup project.

d0a42d6

Add reference to templates setup project.

4a06f5b

Fix up project name

871b45e

Set minimum vs version as 15.0 and update guid of VB template project.

7c9a35d

Add VB class library templates.

e0976f0

Remove templates from core-sdk.sln so that it can open cleanly on VS2…

4096e44

…015.

Add C#\VB specific props\targets and get VB console app to build.

36efb92

Rename classlibrary icon

0e9e79a

Merging with upstream/master

d169bd5

Include OutputType=Library in the props file.

90346b3

natidea reviewed Sep 7, 2016
View reviewed changes

srivatsn added 3 commits September 7, 2016 15:38

Fix NoWarn to just include default value.

b5766e0

Merging with upstream/master

2d008d3

Move the VB project selector the VB template vsix

88d9050

natidea reviewed Sep 8, 2016
View reviewed changes

eerhardt reviewed Sep 8, 2016
View reviewed changes

srivatsn added 2 commits September 8, 2016 09:24

Remove extra characters from target name

bce2815

Update class library templates - target netstandard16, change name, d…

c85d3c1

…escription, icon and sort order.

srivatsn added 4 commits September 8, 2016 12:14

Change directory names to match project names so that dotnet restore …

9c713e0

…generates the targets\props that match the project name

Fix up paths in solution and project files.

e9c611f

Make class libraries target netstandard 1.4

a93e7a1

Add a bug reference to the TODO.

81206b8

Merging with upstream/master

689145c

srivatsn merged commit 0060dac into dotnet:master Sep 9, 2016

srivatsn deleted the templates branch September 9, 2016 00:38

nguerrera pushed a commit that referenced this pull request Oct 10, 2016

Merge pull request #130 from srivatsn/templates

9dca7fc

Adding templates for C# Classlibrary, VB Consoleapp\classlibrary

nguerrera mentioned this pull request Jan 16, 2019

Result of chr() cannot be used as initial value of a Const in .Net Core 3 Preview 1 #2793

Closed

Uh oh!

Adding templates for C# Classlibrary, VB Consoleapp\classlibrary #130

Adding templates for C# Classlibrary, VB Consoleapp\classlibrary #130

Uh oh!

Conversation

srivatsn commented Sep 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

natidea Sep 7, 2016

Choose a reason for hiding this comment

Uh oh!

srivatsn Sep 7, 2016

Choose a reason for hiding this comment

Uh oh!

natidea Sep 8, 2016

Choose a reason for hiding this comment

Uh oh!

srivatsn Sep 8, 2016

Choose a reason for hiding this comment

Uh oh!

natidea commented Sep 8, 2016

Uh oh!

eerhardt Sep 8, 2016

Choose a reason for hiding this comment

Uh oh!

eerhardt commented Sep 8, 2016

Uh oh!

eerhardt Sep 8, 2016

Choose a reason for hiding this comment

Uh oh!

blackdwarf commented Sep 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eerhardt commented Sep 8, 2016

Uh oh!

blackdwarf commented Sep 8, 2016

Uh oh!

srivatsn commented Sep 8, 2016

Uh oh!

srivatsn commented Sep 8, 2016

Uh oh!

srivatsn commented Sep 8, 2016

Uh oh!

srivatsn commented Sep 8, 2016

Uh oh!

srivatsn commented Sep 8, 2016

Uh oh!

eerhardt commented Sep 8, 2016

Uh oh!

mmitche commented Sep 8, 2016

Uh oh!

mmitche commented Sep 8, 2016

Uh oh!

mmitche commented Sep 8, 2016

Uh oh!

eerhardt commented Sep 9, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

srivatsn commented Sep 7, 2016 •

edited

Loading

blackdwarf commented Sep 8, 2016 •

edited

Loading