Condition illink UsingTasks #16907
Merged
Condition illink UsingTasks #16907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UsingTasks cause problems when the .NET SDK targets are imported but the props are not, since ILLinkTasksAssembly is only defined when the .NET SDK props are imported. This is a a slightly broader fix for issues like dotnet#16725, since I'm concerned that scenarios other than C++/CLI may be similar. A more correct fix would be to consistently import the .NET props and targets, but this should at least prevent issues when the unused targets are imported.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
vitek-karas
approved these changes
Apr 15, 2021
eerhardt
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UsingTasks cause problems when the .NET SDK targets are imported but
the props are not, since ILLinkTasksAssembly is only defined when the .NET SDK
props are imported.
This is a a slightly broader fix for issues like #16725,
since I'm concerned that scenarios other than C++/CLI may be similar.
A more correct fix would be to consistently import the .NET props and
targets, but this should at least prevent issues when the unused targets
are imported.