[darc] add ASP.NET dependency for use in dotnet/maui #45998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In .NET 10, we are facing some errors due to MSBuild files containing
mismatched versions:
packages\microsoft.aspnetcore.app.internal.assets\10.0.0-alpha.2.25061.1\build\Microsoft.AspNetCore.App.Internal.Assets.targets
packages\microsoft.aspnetcore.components.webview\10.0.0-alpha.2.25062.2\build\Microsoft.AspNetCore.Components.WebView.props
The version of the first is controlled by the .NET SDK, while the
second by the version of the `Microsoft.AspNetCore.Components.WebView`
package.
To align this, we could add `CoherentParentDependency`:
<Dependency Name="Microsoft.AspNetCore.Components.WebView" Version="10.0.0-alpha.2.25062.2" CoherentParentDependency="Microsoft.NET.Sdk">
<Uri>https://github.com/dotnet/aspnetcore</Uri>
<Sha>a869e316fd72bd8b94dfee3704266260b9c547ab</Sha>
</Dependency>
However, this results in an error such as:
> darc update-dependencies --coherency-only
Checking for coherency updates...
fail: Coherency updates failed for the following dependencies: Unable to update Microsoft.AspNetCore.Components.WebView to have coherency with Microsoft.NET.Sdk: https://github.com/dotnet/sdk @ 60e9a46 does not contain dependency Microsoft.AspNetCore.Components.WebView
- Add the dependency to https://github.com/dotnet/sdk.
To solve this, we can add dependency to dotnet/sdk and dotnet/maui can
align these version numbers going forward. It should also make it so
for dotnet/maui gets the proper ASP.NET versions for release branches.
I added several packages that are used by dotnet/maui.
ghost
added
marcpopMSFT
approved these changes
Jan 15, 2025
This was referenced Jan 15, 2025
Member
Author
|
The one build failure seems unrelated, as I just touched an xml file. Going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In .NET 10, we are facing some errors due to MSBuild files containing mismatched versions:
The version of the first is controlled by the .NET SDK, while the second by the version of the
Microsoft.AspNetCore.Components.WebViewpackage.To align this, we could add
CoherentParentDependency:However, this results in an error such as:
To solve this, we can add dependency to dotnet/sdk and dotnet/maui can align these version numbers going forward. It should also make it so for dotnet/maui gets the proper ASP.NET versions for release branches.
I added several packages that are used by dotnet/maui.