Skip to content

Conversation

@marcpopMSFT
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings May 28, 2025 20:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A PR to exclude specific upstream files related to Emscripten and code coverage from analysis by updating the analyzeTargetGlob patterns.

  • Updated exclusion patterns in the SDK build pipeline YAML file.
  • Added patterns to exclude files from Microsoft.NET.Runtime.Emscripten tools and CodeCoverage directories.
Comments suppressed due to low confidence (1)

eng/pipelines/templates/jobs/sdk-build.yml:61

  • Ensure that the updated exclusion patterns do not inadvertently exclude intended files, and consider adding a comment to clarify the rationale for these exclusions.
analyzeTargetGlob: +:f|eng\**\*.props;+:f|artifacts\bin\**\*.dll;+:f|artifacts\bin\**\*.exe;-:f|artifacts\bin\**\msdia140.dll;-:f|artifacts\bin\**\pgort140.dll;-:f|artifacts\bin\*Tests\**;-f:|**\Microsoft.NET.Runtime.Emscripten**\tools\**.exe;-f:|**\CodeCoverage\**\*.*;

@marcpopMSFT marcpopMSFT force-pushed the marcpopMSFT-addbinskimexclusions branch from 33112bf to efab1dd Compare June 12, 2025 19:41
@marcpopMSFT marcpopMSFT requested a review from MiYanni June 17, 2025 18:15
@marcpopMSFT marcpopMSFT merged commit 7e724fd into main Jun 17, 2025
30 checks passed
@marcpopMSFT marcpopMSFT deleted the marcpopMSFT-addbinskimexclusions branch June 17, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants