Mark SDK bundle as shipping #51413
Merged
Mark SDK bundle as shipping #51413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmitche
approved these changes
Oct 22, 2025
|
Approved by tactics over email. |
|
@joeloff for the insertion tool PR, does this mean that toolset will be stable going forward but the other two won't be? These are the three currently in 10 that are stable branded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #51234 by marking the bundle as shipping. Based on various binlogs, when the final build is marked as release, the bundle is still considered non-shipping, resulting in the full prerelease values included in the version information passed to the bundle.
Testing
Verified a local, official build