Skip to content

Improve clarity of 'dotnet project convert' output directory prompt #51443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2025
Merged

Improve clarity of 'dotnet project convert' output directory prompt #51443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c287504
Initial plan
Copilot Oct 24, 2025
9503ad5
Improve clarity of 'dotnet project convert' output directory prompt
Copilot Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Cli/dotnet/Commands/CliCommandStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1557,7 +1557,7 @@ Tool '{1}' (version '{2}') was successfully installed. Entry is added to the man
<value>Convert a file-based program to a project-based program.</value>
</data>
<data name="ProjectConvertAskForOutputDirectory" xml:space="preserve">
<value>Specify the output directory ({0}):</value>
<value>Specify the output directory (press Enter for default: '{0}', directory must not exist):</value>
Copy link
Member

@baronfel baronfel Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't couple the 'prompt' string and the 'detail' clarification - we need the two texts separate because the 'real' prompt (from Spectre when that is merged) will display the 'detail' clarification (as well as the 'default' value portion of the prompt) in different ways and in different locations.

Copy link
Member

@jjonescz jjonescz Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know Spectre prompts had some detail clarification part (I don't see it in the docs either).

As for the default part, Spectre doesn't allow customizing that other than via the prompt text anyway, like

new TextPrompt<T>($"...original prompt... [grey](default: {Markup.Escape($"{defaultValue}")})[/]:")
  .DefaultValue(defaultValue)
  .HideDefaultValue();

(note that this should currently be done always if the default value can be arbitrary to avoid spectreconsole/spectre.console#1181 as Spectre doesn't Markup.Escape the default value itself)

So I'm unsure how exactly you imagine the split here - and anyway that sounds like premature refactoring unless we actually have Spectre.

Copy link
Member

@jjonescz jjonescz Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baronfel ping

Copy link
Member

@baronfel baronfel Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for digging in, what you have is fine given that. I think the SDK will want to make a 'prompt' component for reuse as part of the overall input/output consistency work we want to do for 11, so we can address my thoughts then :)

<comment>{0} is the default value</comment>
</data>
<data name="ProjectConvertDryRun" xml:space="preserve">
Expand Down
4 changes: 2 additions & 2 deletions src/Cli/dotnet/Commands/xlf/CliCommandStrings.cs.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/Cli/dotnet/Commands/xlf/CliCommandStrings.de.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/Cli/dotnet/Commands/xlf/CliCommandStrings.es.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/Cli/dotnet/Commands/xlf/CliCommandStrings.fr.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/Cli/dotnet/Commands/xlf/CliCommandStrings.it.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/Cli/dotnet/Commands/xlf/CliCommandStrings.ja.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/Cli/dotnet/Commands/xlf/CliCommandStrings.ko.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/Cli/dotnet/Commands/xlf/CliCommandStrings.pl.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/Cli/dotnet/Commands/xlf/CliCommandStrings.pt-BR.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/Cli/dotnet/Commands/xlf/CliCommandStrings.ru.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/Cli/dotnet/Commands/xlf/CliCommandStrings.tr.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/Cli/dotnet/Commands/xlf/CliCommandStrings.zh-Hans.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/Cli/dotnet/Commands/xlf/CliCommandStrings.zh-Hant.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.