Fix CODEOWNERS for CLI commands directories #51668
Merged
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
requested review from
MiYanni,
baronfel and
Copilot
and removed request for
MiYanni and
Copilot
Copilot finished reviewing on behalf of
Youssef1313
November 11, 2025 22:57
Youssef1313
commented
Nov 12, 2025
CODEOWNERS
Outdated
Comment on lines
56
to
57
| /test/dotnet-test.Tests @dotnet/dotnet-testing-admin | ||
| /test/dotnet-vstest.Tests @dotnet/dotnet-testing-admin |
Member
Author
There was a problem hiding this comment.
These directories don't exist currently 👀
Member
Author
There was a problem hiding this comment.
Probably should be:
test/dotnet.Tests/CommandTests/Test
test/dotnet.Tests/CommandTests/VSTest
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CODEOWNERS file paths to correctly reference CLI command directories with proper casing and structure.
- Updated source directory paths from lowercase
commands/dotnet-*pattern to PascalCaseCommands/*pattern - Corrected test directory paths for Test and VSTest commands to point to the actual
dotnet.Tests/CommandTests/*structure - Fixed path references for Format, Fsi, New, Test, and VSTest command directories
Member
Author
|
@baronfel Please review |
baronfel
approved these changes
Nov 18, 2025
Member
|
/ba-g stuck |
Member
|
Good find. Definitely something I missed when I moved the directories around earlier this year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.