Skip to content

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Nov 18, 2025

Closes #51521

I think the PR might fail currently, but hopefully will pass after #51411 is merged.

Copilot AI review requested due to automatic review settings November 18, 2025 10:29
Copilot finished reviewing on behalf of Youssef1313 November 18, 2025 10:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the path separator convention in solution filter (.slnf) test assets to use double backslashes (\\) instead of forward slashes. The change aligns these test assets with the JSON format standard and the existing convention used in all other .slnf files in the repository, where backslashes must be escaped in JSON strings.

Key Changes:

  • Updated path separators from / to \\ in .slnf test asset files to match the repository-wide convention

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/TestAssets/TestProjects/MultiTestProjectSolutionWithTests/TestProjects.slnf Changed project path separator from / to \\
test/TestAssets/TestProjects/MultiTestProjectSolutionWithTests/SolutionFilter/OtherTestProjects.slnf Changed both solution path and project path separators from / to \\

@Youssef1313
Copy link
Member Author

[xUnit.net 00:02:14.69]     Microsoft.DotNet.Cli.Test.Tests.GivenDotnetTestBuildsAndRunsTestsWithDifferentOptions.RunWithSolutionFilterPathInOtherDirectory_ShouldReturnExitCodeGenericFailure(configuration: "Debug") [OUTPUT] ❌Could not find solution or directory `/private/tmp/helix/working/AC330920/t/dotnetSdkTests.A6sEr5wd/a7b04b23-5863---FEB8A6C7/SolutionFilter/..\MultiTestProjectSolutionWithTests.sln`.
< /tmp/helix/working/AC330920/p/d/dotnet test --configuration Debug exited with 1 in 454 ms.

Let's see after #51411.

@Youssef1313 Youssef1313 force-pushed the dev/ygerges/update-slnf-test-assets branch from f3e246b to 9b50da6 Compare November 18, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dotnet test --solution fails to resole path with backslash in solution filter on Linux

3 participants