Skip to content

Fix test duration display to not show "(0ms)" when duration is unavailable #51792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2025
+12 −9
Merged

Fix test duration display to not show "(0ms)" when duration is unavailable #51792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4358d4
Initial plan
Copilot Nov 18, 2025
8df5950
Fix test duration display to not show 0 when duration is null
Copilot Nov 18, 2025
90c4ab8
Cleanup
Youssef1313 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/Cli/dotnet/Commands/Test/MTP/Terminal/TerminalTestReporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

using System.Collections.Concurrent;
using Microsoft.TemplateEngine.Cli.Help;
using System.Globalization;
using System.Text.RegularExpressions;
using Microsoft.CodeAnalysis;
using Microsoft.Testing.Platform.OutputDevice.Terminal;
using Microsoft.DotNet.Cli.Commands.Test.IPC.Models;
using Microsoft.TemplateEngine.Cli.Help;
using Microsoft.Testing.Platform.OutputDevice.Terminal;

namespace Microsoft.DotNet.Cli.Commands.Test.Terminal;

Expand Down Expand Up @@ -397,7 +397,7 @@ internal void TestCompleted(
string displayName,
string? informativeMessage,
TestOutcome outcome,
TimeSpan duration,
TimeSpan? duration,
FlatException[]? exceptions,
string? expected,
string? actual,
Expand Down Expand Up @@ -458,7 +458,7 @@ internal void TestCompleted(
string displayName,
string? informativeMessage,
TestOutcome outcome,
TimeSpan duration,
TimeSpan? duration,
FlatException[]? flatExceptions,
string? expected,
string? actual,
Expand Down Expand Up @@ -496,9 +496,12 @@ internal void TestCompleted(
terminal.ResetColor();
terminal.Append(' ');
terminal.Append(displayName);
terminal.SetColor(TerminalColor.DarkGray);
terminal.Append(' ');
AppendLongDuration(terminal, duration);

if (duration.HasValue)
{
terminal.Append(' ');
AppendLongDuration(terminal, duration.Value);
}

if (!string.IsNullOrEmpty(informativeMessage))
{
Expand Down
4 changes: 2 additions & 2 deletions src/Cli/dotnet/Commands/Test/MTP/TestApplicationHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ internal void OnTestResultsReceived(TestResultMessages testResultMessage)
testResult.DisplayName!,
testResult.Reason,
ToOutcome(testResult.State),
TimeSpan.FromTicks(testResult.Duration ?? 0),
testResult.Duration.HasValue ? TimeSpan.FromTicks(testResult.Duration.Value) : null,
exceptions: null,
expected: null,
actual: null,
Expand All @@ -158,7 +158,7 @@ internal void OnTestResultsReceived(TestResultMessages testResultMessage)
testResult.DisplayName!,
testResult.Reason,
ToOutcome(testResult.State),
TimeSpan.FromTicks(testResult.Duration ?? 0),
testResult.Duration.HasValue ? TimeSpan.FromTicks(testResult.Duration.Value) : null,
exceptions: [.. testResult.Exceptions!.Select(fe => new Terminal.FlatException(fe.ErrorMessage, fe.ErrorType, fe.StackTrace))],
expected: null,
actual: null,
Expand Down
Loading