[release/10.0.1xx] Fix solution parsing in dotnet test for Microsoft.Testing.Platform #51794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #51411
Description
This PR backports #51411. It's a fix for dotnet test for Microsoft.Testing.Platform (a new feature in .NET 10) where we didn't parse solution files correctly. This resulted in two categories of issues:
ConfigurationandPlatformglobal properties. Normally, when building a solution, projects are passedConfigurationandPlatformglobal properties. The lack of passing these global properties can result in wrong evaluation in the project, for example, ending up looking for the test executable in the wrong directory, and failing because it's not found.Customer Impact
This was reported both internally and externally. Related issues:
dotnet testshould respect platform #51481Regression?
Technically no, it's a new feature. But if a user is migrating from VSTest to Microsoft.Testing.Platform, they might view it as a regression.
Risk
Low.