ClickOnce: "some errors were encountered"

[dtivel]

Repro steps

1. Create a .NET 7.0 C# WinForms application project named WinFormsApp1.

2. Create a ClickOnce publishing profile without manifest signing.

3. Publish to bin\publish.

4. Compress the publish folder into ZIP file named publish.clickonce.

5. Create a file named filelist.txt with the following content:

   **/WinFormsApp1.*
   **/setup.exe
   

6. Execute:

   sign code azure-key-vault -kvu **** -kvc MyCertificate -kvm -d Description -u http://description.test -t http://timestamp.digicert.com -b E:\testpass -fl .\filelist.txt .\publish.clickonce
   

Result

PS E:\testpass> sign code azure-key-vault -kvu **** -kvc MyCertificate -kvm -d Description -u http://description.test -t http://timestamp.digicert.com -b E:\testpass -fl .\filelist.txt .\publish.clickonce
info: Sign.Core.Signer[0]
      Submitting E:\testpass\publish.clickonce for signing.
info: Sign.Core.Signer[0]
      SignAsync called for E:\testpass\publish.clickonce. Using C:\Users\dtivel\AppData\Local\Temp\2iemu1ts.tva\t2ulumpx.clickonce locally.
info: Sign.Core.IDirectoryService[0]
      Extracting container C:\Users\dtivel\AppData\Local\Temp\2iemu1ts.tva\t2ulumpx.clickonce to C:\Users\dtivel\AppData\Local\Temp\ktvqu3ao.cpw.
info: Sign.Core.ISignatureProvider[0]
      Signing SignTool job with 1 files.
info: Sign.Core.ISignatureProvider[0]
      Signing SignTool job with 2 files.
info: Sign.Core.ISignatureProvider[0]
      Signing C:\Users\dtivel\AppData\Local\Temp\ktvqu3ao.cpw\publish\Application Files\WinFormsApp1_1_0_0_0\WinFormsApp1.exe.deploy.
info: Sign.Core.ISignatureProvider[0]
      Signing C:\Users\dtivel\AppData\Local\Temp\ktvqu3ao.cpw\publish\setup.exe.
info: Sign.Core.ISignatureProvider[0]
      Signing C:\Users\dtivel\AppData\Local\Temp\ktvqu3ao.cpw\publish\Application Files\WinFormsApp1_1_0_0_0\WinFormsApp1.dll.deploy.
info: Sign.Core.ISignatureProvider[0]
      Signing succeeded.
info: Sign.Core.ISignatureProvider[0]
      Signing succeeded.
info: Sign.Core.ISignatureProvider[0]
      Signing succeeded.
info: Sign.Core.IDirectoryService[0]
      Rebuilding container C:\Users\dtivel\AppData\Local\Temp\2iemu1ts.tva\t2ulumpx.clickonce from C:\Users\dtivel\AppData\Local\Temp\ktvqu3ao.cpw.
info: Sign.Core.ISignatureProvider[0]
      Signing Mage job with 1 files.
info: Sign.Core.IDirectoryService[0]
      Extracting container C:\Users\dtivel\AppData\Local\Temp\2iemu1ts.tva\t2ulumpx.clickonce to C:\Users\dtivel\AppData\Local\Temp\pjbonkno.ztf.
info: Sign.Core.ISignatureProvider[0]
      Signing SignTool job with 3 files.
info: Sign.Core.ISignatureProvider[0]
      Signing C:\Users\dtivel\AppData\Local\Temp\pjbonkno.ztf\publish\Application Files\WinFormsApp1_1_0_0_0\WinFormsApp1.dll.
info: Sign.Core.ISignatureProvider[0]
      Signing C:\Users\dtivel\AppData\Local\Temp\pjbonkno.ztf\publish\Application Files\WinFormsApp1_1_0_0_0\WinFormsApp1.exe.
info: Sign.Core.ISignatureProvider[0]
      Signing C:\Users\dtivel\AppData\Local\Temp\pjbonkno.ztf\publish\setup.exe.
info: Sign.Core.ISignatureProvider[0]
      Signing succeeded.
info: Sign.Core.ISignatureProvider[0]
      Signing succeeded.
info: Sign.Core.ISignatureProvider[0]
      Signing succeeded.
info: Sign.Core.IMageCli[0]
      Running mage.exe with parameters: '-update "C:\Users\dtivel\AppData\Local\Temp\pjbonkno.ztf\publish\Application Files\WinFormsApp1_1_0_0_0\WinFormsApp1.dll.manifest" -a sha256RSA'.
info: Sign.Core.IMageCli[0]
      mage.exe Out Warning MSB3178: Assembly 'WinFormsApp1.dll' is incorrectly specified as a file.

      WinFormsApp1.dll.manifest successfully updated. However, some errors were encountered.

info: Sign.Core.ISignatureProvider[0]
      Signing succeeded.
info: Sign.Core.IMageCli[0]
      Running mage.exe with parameters: '-update "C:\Users\dtivel\AppData\Local\Temp\pjbonkno.ztf\publish\WinFormsApp1.application" -a sha256RSA -appm "C:\Users\dtivel\AppData\Local\Temp\pjbonkno.ztf\publish\Application Files\WinFormsApp1_1_0_0_0\WinFormsApp1.dll.manifest" -pub "Test certificate (DO NOT TRUST)"  -SupportURL http://description.test/'.
info: Sign.Core.IMageCli[0]
      mage.exe Out WinFormsApp1.application successfully updated

info: Sign.Core.ISignatureProvider[0]
      Signing succeeded.
info: Sign.Core.IDirectoryService[0]
      Rebuilding container C:\Users\dtivel\AppData\Local\Temp\2iemu1ts.tva\t2ulumpx.clickonce from C:\Users\dtivel\AppData\Local\Temp\pjbonkno.ztf.
info: Sign.Core.Signer[0]
      Successfully signed E:\testpass\publish.clickonce in 21779 ms

[dtivel]

This is where the warning is raised.

[dtivel]

Confirmed with @NikolaMilosavljevic that this warning is ignorable. For .NET app deployments, all payload files are added as regular files, and this triggers the warning. Some work was done in MSBuild to ignore this warning, but Mage.exe uses MSBuild from .NET Framework 4.7.2 which wasn't updated to ignore this warning.

If we update to dotnet-mage this warning will be suppressed. Until then, it's just noise.

[dtivel]

Should be resolved by #479.