Enable Nuget Audit #1149
Merged
Enable Nuget Audit #1149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSimons
requested review from
a team and
ViktorHofer
and removed request for
a team
ViktorHofer
approved these changes
Feb 4, 2025
Member
There was a problem hiding this comment.
LGTM. Consider also setting this so that local builds aren't blocked when there's a new advisory: https://github.com/dotnet/arcade/blob/5d30877b1eb318583acd5f2cd3f3a80e77b3add2/Directory.Build.props#L17-L18
mthalman
approved these changes
Feb 4, 2025
Member
Author
WarningsAsErrors was not enabled anywhere. It doesn't make sense to enable WarningsAsErrors for any of the ref packs but it does make sense for the generate tooling so I enabled it there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#4673.
Enabled the NuGet Audit functionality for the SBRP repo but disabled it for the reference and targeting packages given they contain no implementation. It is enabled for the generate tooling as well as the text only packages.