Skip to content

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Feb 28, 2025

Fixes dotnet/source-build#4482

Commit 1

Remove netstandard1.x only packages that weren't removed in f0ea129. My guess is that they weren't reported because Microsoft.NetCore.Targets/1.1.0 depended on them (which also gets removed now as part of this commit). So there was a cycle which hindered the tooling to flag all those packages.

  1. I manually removed all the package folders that were netstandard1.x only.
  2. I then updated all projects that targeted netstandard1.x by removing the TFM string from the TargetFrameworks property and removed item groups conditioned on the TFM.
  3. Updated the nuspec to remove the group TFM entries
  4. Deleted the sources for the removed TFMs

I forgot to mention that this PR also removes a few netcoreapp1.x leftover packages which have the same matching 4.3.0 version as the netstandard1.x packages.

Commit 2

Filter out netstandard1.x TFMs when generating new packages with the PackageSourceGenerator tooling.

@ViktorHofer ViktorHofer requested a review from a team as a code owner February 28, 2025 10:29
@ViktorHofer ViktorHofer force-pushed the RemoveUnusedSBRPsNew branch 2 times, most recently from cca61ea to f8d00be Compare February 28, 2025 13:15
@ViktorHofer ViktorHofer changed the title Remove unused SBRPs Remove unused SBRPs (which includes everything netstandard1.x) Feb 28, 2025
@ViktorHofer ViktorHofer added the no-merge Do not merge label Feb 28, 2025
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Feb 28, 2025

NO merge until we validated this with a VMR source-only build: dotnet/sdk#47191

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Feb 28, 2025

OK after talking to @MichaelSimons offline, he let me know that this PR removes a few packages that are still used and aren't reported correctly by the tooling: dotnet/source-build#4924

He also suggested to wait until #1181 is merged to make this PR focused on just the netstandard1.x removal. I will drop commit 1 and rebase on top of main when the other PR is merged which will also make commit 3 and 4 go away.

@ViktorHofer ViktorHofer deleted the RemoveUnusedSBRPsNew branch February 28, 2025 16:23
@MichaelSimons MichaelSimons restored the RemoveUnusedSBRPsNew branch February 28, 2025 16:41
@MichaelSimons MichaelSimons reopened this Feb 28, 2025
@MichaelSimons
Copy link
Member

I queued a full VMR test build at dotnet/sdk#47172

@ViktorHofer ViktorHofer changed the title Remove unused SBRPs (which includes everything netstandard1.x) Remove netstandard1.x packages and support infrastructure Feb 28, 2025
@ViktorHofer ViktorHofer removed the no-merge Do not merge label Feb 28, 2025
@MichaelSimons MichaelSimons merged commit e8bfb5c into main Feb 28, 2025
4 checks passed
@ViktorHofer ViktorHofer deleted the RemoveUnusedSBRPsNew branch February 28, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove netstandard1.x assets from SBRP

2 participants