-
Couldn't load subscription status.
- Fork 67
Remove netstandard1.x packages and support infrastructure #1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fca9466 to
2ad2f39
Compare
cca61ea to
f8d00be
Compare
|
NO merge until we validated this with a VMR source-only build: dotnet/sdk#47191 |
Try changes made in dotnet/source-build-reference-packages#1179
|
OK after talking to @MichaelSimons offline, he let me know that this PR removes a few packages that are still used and aren't reported correctly by the tooling: dotnet/source-build#4924 He also suggested to wait until #1181 is merged to make this PR focused on just the netstandard1.x removal. I will drop commit 1 and rebase on top of main when the other PR is merged which will also make commit 3 and 4 go away. |
47165f0 to
16af257
Compare
|
I queued a full VMR test build at dotnet/sdk#47172 |
Fixes dotnet/source-build#4482
Commit 1
Remove netstandard1.x only packages that weren't removed in f0ea129. My guess is that they weren't reported because
Microsoft.NetCore.Targets/1.1.0depended on them (which also gets removed now as part of this commit). So there was a cycle which hindered the tooling to flag all those packages.I forgot to mention that this PR also removes a few netcoreapp1.x leftover packages which have the same matching
4.3.0version as the netstandard1.x packages.Commit 2
Filter out netstandard1.x TFMs when generating new packages with the PackageSourceGenerator tooling.