Skip to content

Exclude netstandard1.x TFMs from PackageSourceGenerator.proj #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Exclude netstandard1.x TFMs from PackageSourceGenerator.proj #1180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1b4947
Exclude netstandard1.x TFMs from PackageSourceGenerator.proj
ViktorHofer Feb 28, 2025
4e0d2fe
Update netstandard1.x test packages
ViktorHofer Feb 28, 2025
b77bb64
Update package
ViktorHofer Feb 28, 2025
8e0faa6
update test again
ViktorHofer Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/packageSourceGenerator/PackageSourceGenerator.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<ExcludeTargetFrameworks>monoandroid*;monotouch*;net20;net35;net4*;netcore50;netcoreapp2.*;portable*;uap*;win8;win81;wp8;wpa81;xamarin*</ExcludeTargetFrameworks>
<!-- The following target frameworks should be excluded even though they are supported by the current SDK because there is no need to have them.
Only exclude them when target frameworks to include aren't provided. -->
<ExcludeTargetFrameworks Condition="'$(IncludeTargetFrameworks)' == ''">$(ExcludeTargetFrameworks);netcoreapp3.1</ExcludeTargetFrameworks>
<ExcludeTargetFrameworks Condition="'$(IncludeTargetFrameworks)' == ''">$(ExcludeTargetFrameworks);netcoreapp3.1;netstandard1*</ExcludeTargetFrameworks>
</PropertyGroup>

<PropertyGroup Condition="'$(PackageName)' != '' and '$(PackageVersion)' != ''">
Expand Down
3 changes: 1 addition & 2 deletions tests/SbrpTests/GenerateScriptTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,9 @@ public enum PackageType

public static IEnumerable<object[]> Data => new List<object[]>
{
new object[] { "System.Xml.ReaderWriter", "4.3.0", PackageType.Reference },
new object[] { "Microsoft.Extensions.Logging.Abstractions", "6.0.4", PackageType.Reference },
new object[] { "Microsoft.CodeAnalysis.CSharp", "3.11.0", PackageType.Reference },
new object[] { "System.Security.Cryptography.Encoding", "4.3.0", PackageType.Reference },
new object[] { "System.Security.Cryptography.ProtectedData", "8.0.0", PackageType.Reference },
new object[] { "Microsoft.Build.NoTargets", "3.7.0", PackageType.Text },
};

Expand Down