Generated .version file for source build artifacts not working with stable versioning

[mthalman]

The changes in dotnet/installer#17625 caused a test failure which validates the content of the .version file that gets generated for the source build artifacts:

Assert.Equal() Failure
↓ (pos 7)
Expected: 8.0.100
Actual:   8.0.100-rtm.23527.1
↑ (pos 7)

 at Microsoft.DotNet.SourceBuild.SmokeTests.SourceBuiltArtifactsTests.VerifyVersionFile() in /vmr/test/Microsoft.DotNet.SourceBuild.SmokeTests/SourceBuiltArtifactsTests.cs:line 61
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

This is because that PR introduced stable versioning for installer. This conflicts with the logic which populates that .version file. That uses the version of installer's source build intermediate which is not stable versioned.

[mthalman]

A change was made to disable this check in the test to unblock the PR: dotnet/installer@b49f63c It should be re-enabled when fixing this issue.

[MichaelSimons]

@NikolaMilosavljevic - Is this something you can help out with? I'd like to see a fix if plausible be included in Dec servicing. TIA

[mthalman]

A simpler solution would be to just extract the .version file from the MS SDK and use the version from that. That will always keep it in alignment.

[NikolaMilosavljevic]

A simpler solution would be to just extract the .version file from the MS SDK and use the version from that. That will always keep it in alignment.

Do we still want to use the 'unstable' version in PSB artifact name, or should that also match the SDK version?

https://github.com/dotnet/installer/blob/fb7c9717cfd661b120e900a073c60a8fc9e898da/src/SourceBuild/content/repo-projects/package-source-build.proj#L57C15-L57C15

<SourceBuiltTarballName>$(OutputPath)$(SourceBuiltArtifactsTarballName).$(MicrosoftSourceBuildIntermediateInstallerVersion).$(TargetRid).tar.gz</SourceBuiltTarballName>

By 'MS SDK' I presume this was referring to dotnet-sdk-*.tar.gz package built in source-build. Later, in smoke-tests, we'd compare this version to the version extracted from real MS-built SDK.