Missing source information causing "identical line collapsing" in VsCode Debug Console

[tebeco]

Hello everyone,

TLDR:
"Ominisharp console output" is not providing "Source Information" to VsCode
microsoft/vscode#141218

Description (using browser)

Yesterday we noticed that when debugging inside VsCode some code that tried to write to StdOut, these lines could be collapsed.
This is the same things that you could see on Chromium-based browser.
Remember for later that the first example is not grouping while the second one is.

This can also be tempered with:

In VsCode

Javascript:

C# / F#:

Settings ?

We opened an issue on VsCode and we were hinted at:

issue is ... we did not knew or set it, meaning we were running with the default value all along and still have 2 different output on the same settings which lead us here:

From @weinand => microsoft/vscode#141218

If console output provides source information (in the following screenshot on the right hand side), then lines are only collapsed if their source is identical. @isidorn is this correct?
The following example shows that identical lines are collapsed in Node.js for the loop but not for individual console.log statements:

If a debug extension does not provide source information, then identical are always collapsed. This seems to be the case for C# and F#.

[filipw]

This is an issue of the C# Extension, not OmniSharp. I will move it.

[tebeco]

edit: nvm got it, it was 50-50 this one or the one you moved it to

[nohwnd]

@gregg-miskelly Please have a look.

[gregg-miskelly]

From the C# extension perspective, this is "by design" -- C# doesn't know the source of calls to Console.WriteLine (or similar APIs). I would agree that if I was deciding, I would not have enabled debug.console.collapseIdenticalLines by default, but there is nothing for the C# extension to do.

[tebeco]

the question is ... does it only affect debug.console.collapseIdenticalLines (the fact that it's missing source information) ?

[gregg-miskelly]

Proving source references is optional, so, if VS Code had a place where it was requiring them (which I don't think it does), that would be a bug in VS Code.

[tebeco]

fine for me l, just double checking

[weinand]

I think we (VS Code) should consider not to collapse lines if there is no source info available.

@gregg-miskelly your opinion?