Skip to content

A non awaiting version of the context provider registration code. #8616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

A non awaiting version of the context provider registration code. #8616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 46 additions & 42 deletions src/lsptoolshost/copilot/contextProviders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,17 +76,8 @@ export function registerCopilotContextProviders(
return;
}

devkit.activate().then(async () => {
devkit.activate().then(() => {
try {
const copilotClientApi = await getCopilotClientApi();
const copilotChatApi = await getCopilotChatApi();
if (!copilotClientApi && !copilotChatApi) {
channel.debug(
'Failed to find compatible version of GitHub Copilot extension installed. Skip registration of Copilot context provider.'
);
return;
}

const provider: ContextProvider<SupportedContextItem> = {
id: CSharpExtensionId, // use extension id as provider id for now
selector: [{ language: 'csharp' }],
Expand All @@ -106,30 +97,50 @@ export function registerCopilotContextProviders(
},
},
};

let installCount = 0;
if (copilotClientApi) {
const disposable = await installContextProvider(copilotClientApi, provider);
if (disposable) {
context.subscriptions.push(disposable);
installCount++;
}
}
if (copilotChatApi) {
const disposable = await installContextProvider(copilotChatApi, provider);
if (disposable) {
context.subscriptions.push(disposable);
installCount++;
}
}

if (installCount === 0) {
channel.debug(
'Incompatible GitHub Copilot extension installed. Skip registration of C# context providers.'
);
return;
}
channel.debug('Registration of C# context provider for GitHub Copilot extension succeeded.');
getCopilotClientApi()
.then(async (api) => {
if (!api) {
channel.debug(
'Failed to find compatible version of GitHub Copilot extension installed. Skip registration of Copilot context provider.'
);
return;
}
const disposable = await installContextProvider(api, provider);
if (disposable) {
context.subscriptions.push(disposable);
channel.debug('Registration of C# context provider for GitHub Copilot extension succeeded.');
} else {
channel.debug(
'Incompatible GitHub Copilot extension installed. Skip registration of C# context providers.'
);
}
})
.catch((error) => {
channel.error('Failed to register Copilot context providers', error);
});
getCopilotChatApi()
.then(async (api) => {
if (!api) {
channel.debug(
'Failed to find compatible version of GitHub Copilot Chat extension installed. Skip registration of Copilot context provider.'
);
return;
}
const disposable = await installContextProvider(api, provider);
if (disposable) {
context.subscriptions.push(disposable);
channel.debug(
'Registration of C# context provider for GitHub Copilot Chat extension succeeded.'
);
} else {
channel.debug(
'Incompatible GitHub Copilot Chat extension installed. Skip registration of C# context providers.'
);
}
})
.catch((error) => {
channel.error('Failed to register Copilot Chat context providers', error);
});
} catch (error) {
channel.error('Failed to register Copilot context providers', error);
}
Expand Down Expand Up @@ -157,14 +168,7 @@ async function getCopilotChatApi(): Promise<CopilotApi | undefined> {

let exports: CopilotChatApi | undefined;
try {
exports = await Promise.race([
extension.activate(),
new Promise<undefined>((resolve) => {
setTimeout(() => {
resolve(undefined);
}, 3000);
}),
]);
exports = await extension.activate();
} catch {
return undefined;
}
Expand Down
Loading