Only Check for Existing Installs if Offline on SDK Admin Installs #2497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves dotnet#2476 2 core issues are resolved in this change: 1. https://github.com/dotnet/vscode-dotnet-runtime/pulls?q=is%3Apr+is%3Aclosed made it so that we skip the offline check before reusing existing installs. The runtime install is automated and we update it automatically so it's ok to use an older runtime version for the acquire API if forceUpdate is not true. For the SDK, we don't update automatically, so we shouldn't use the existing install of the same major.minor unless we are offline and can't do anything. You could debate whether we'd want to do that either, but we've leaned towards minimizing friction. 2: The check to get a major minor failed if the version was not fully quantified. We should be able to handle that better. Also improves test coverage.
nagilson
commented
Nov 25, 2025
joeloff
reviewed
Nov 25, 2025
joeloff
reviewed
Nov 25, 2025
joeloff
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2476
2 core issues are resolved in this change:
1:
https://github.com/dotnet/vscode-dotnet-runtime/pulls?q=is%3Apr+is%3Aclosed made it so that we skip the offline check before reusing existing installs. The runtime install is automated and we update it automatically so it's ok to use an older runtime version for the acquire API if forceUpdate is not true. For the SDK, we don't update automatically, so we shouldn't use the existing install of the same major.minor unless we are offline and can't do anything. You could debate whether we'd want to do that either, but we've leaned towards minimizing friction.
2:
The check to get a major minor failed if the version was not fully quantified. We should be able to handle that better.
3:
Updates dependencies. Normally this would be a separate PR, but there is a lot of OOF during the holidays and it will be easier to get this through with 1 PR.
Also improves test coverage.